Skip to content

Commit 85ce5b3

Browse files
Avi-RobustaSheeproidmershalaantn
authored
New Evals for newrelic (#983)
Co-authored-by: Tomer Keshet <[email protected]> Co-authored-by: mershal <[email protected]> Co-authored-by: Robusta Runner <[email protected]>
1 parent 4c18d7b commit 85ce5b3

File tree

24 files changed

+3086
-621
lines changed

24 files changed

+3086
-621
lines changed

holmes/plugins/prompts/_fetch_logs.jinja2

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ Tools to search and fetch logs from Datadog.
4545
* IMPORTANT: If a limit was applied, ALWAYS tell the user how many logs were shown vs total (e.g., "Showing latest <Y> of <Z> logs")
4646
* IMPORTANT: If any filters were applied, ALWAYS mention them explicitly
4747
{%- elif k8s_yaml_ts and k8s_yaml_ts.status == "enabled" -%}
48+
### Logs from newrelic
49+
* you can fetch logs from newrelic if this is toolset is enabled
4850
### kubernetes/logs
4951
#### Kubernetes Logs Toolset
5052
Tools to search and fetch logs from Kubernetes.
@@ -65,4 +67,5 @@ DO NOT use `--tail` or `| tail` when calling `kubectl logs` because you may miss
6567
** 'opensearch/logs'
6668
** 'coralogix/logs'
6769
** 'datadog/logs'
70+
** 'newrelic'
6871
{%- endif -%}

holmes/plugins/toolsets/newrelic/newrelic.jinja2

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ Note: Use `SHOW EVENT TYPES` to see all event types in the account, in addition
2828
#### 3. Querying Traces
2929
- Always validate first: run the base query without FACET (or a quick LIMIT) to confirm data exists; if results are empty, adjust filters or time range before proceeding.
3030
- Only attempt a FACET after confirming the field has values; if not, either try known alternatives or skip faceting entirely.
31+
- When investigating a trace also look at attributes
32+
- ***When investigating latency ALWAYS look to deliver the specific component or attribute in the span causing significant latnecy*** your investigation is not complete without this
3133

3234
### 3. Metrics/graphs
3335
- You always need to embed the partial result in your response. Include the "tool_name" and "random_key". For example: << {"type": "newrelicql", "tool_name": "execute_prometheus_range_query", "random_key": "92jf2hf"} >>

holmes/plugins/toolsets/newrelic/newrelic.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ def __init__(self):
222222
tools=[
223223
ExecuteNRQLQuery(self),
224224
],
225-
experimental=True,
225+
experimental=False,
226226
tags=[ToolsetTag.CORE],
227227
)
228228
template_file_path = os.path.abspath(

pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,15 @@ scripts_are_modules = true
8484
exclude = [
8585
"tests/llm/fixtures/.*",
8686
"dist/.*",
87+
"site/.*",
8788
]
8889

8990
[tool.pytest.ini_options]
9091
markers = [
9192
"llm: Evaluate LLM behaviour (prompt, tools, etc.)",
9293
"datetime: Tests involving datetime functionality",
9394
"logs: Tests involving log processing",
95+
"metrics: Tests involving metrics processing",
9496
"context_window: Tests involving context window handling",
9597
"synthetic: Tests using synthetic data",
9698
"network: Tests requiring network connectivity",

0 commit comments

Comments
 (0)