Skip to content

postmortem for 0.5.0a0 #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/recipe/meta.yaml.in
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{% set name = "robotframework-jupyterlibrary" %}
{% set version = "REPLACE_THIS_VERSION" %}

package:
name: {{ name }}
name: robotframework-jupyterlibrary
version: {{ version }}

source:
# url: https://pypi.io/packages/source/r/robotframework-jupyterlibrary/robotframework_jupyterlibrary-{{ version }}.tar.gz
url: REPLACE_THIS_PATH
sha256: REPLACE_THIS_SHA256

Expand Down Expand Up @@ -33,11 +33,15 @@ test:
- pip check

about:
home: https://github.com/robots-from-jupyter/{{ name }}
home: https://github.com/robots-from-jupyter/robotframework-jupyterlibrary
license: BSD-3-Clause
license_family: BSD
license_file: LICENSE
summary: A Robot Framework library for testing Jupyter end-user applications and extensions
doc_url: https://{{ name }}.readthedocs.io
dev_url: https://github.com/robots-from-jupyter/{{ name }}
doc_source_url: https://github.com/robots-from-jupyter/{{ name }}/tree/main/docs
doc_url: https://robotframework-jupyterlibrary.readthedocs.io
doc_source_url: https://github.com/robots-from-jupyter/robotframework-jupyterlibrary/tree/v{{ version }}/docs

extra:
recipe-maintainers:
- martinRenou
- bollwyvl
9 changes: 9 additions & 0 deletions _scripts/project.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import os
import platform
import shutil
import subprocess
import sys
from pathlib import Path

Expand Down Expand Up @@ -361,3 +362,11 @@ def get_ok_actions(p: Path):
lambda: p.unlink() if p.exists() else None,
lambda: [p.parent.mkdir(exist_ok=True, parents=True), p.touch(), None][-1],
]


def get_source_date_epoch():
"""Get the SOURCE_DATE_EPOCH from git."""
return subprocess.check_output(
["git", "log", "-1", "--format=%ct"],
encoding="utf-8",
).strip()
16 changes: 16 additions & 0 deletions docs/HISTORY.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,22 @@
"# HISTORY"
]
},
{
"cell_type": "markdown",
"metadata": {},
"source": [
"## 0.5.0a1\n",
"\n",
"| Products under test | Versions |\n",
"|-----------------------------|-----------------------|\n",
"| Python | `3.8.16`<br/>`3.11.3` |\n",
"| CodeMirror | `5`<br/>`6` |\n",
"| Robot Framework | `5.0.1`<br/>`6.0.2` |\n",
"| Jupyter Notebook | `6.5.4`<br/>`7.0.0b3` |\n",
"| JupyterLab | `3.6.4`<br/>`4.0.1` |\n",
"| Jupyter Server | `2.6.0` |"
]
},
{
"cell_type": "markdown",
"metadata": {},
Expand Down
7 changes: 6 additions & 1 deletion dodo.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,15 @@ def task_build():
env_lock = P.CONDA_LISTS[env]
run_in = P.RUN_IN[env]

def _flit_build():
env = dict(os.environ, SOURCE_DATE_EPOCH=P.get_source_date_epoch())
rc = subprocess.call([*run_in, "flit", "--debug", "build"], env=env)
return rc == 0

yield {
"name": "pypi",
"doc": "build the pypi sdist/wheel",
"actions": [[*run_in, "flit", "build"]],
"actions": [_flit_build],
"targets": [P.SDIST, P.WHEEL],
"file_dep": [*P.PY_SRC, *P.ROBOT_SRC, *P.SETUP_CRUFT, env_lock],
}
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name = "JupyterLibrary"

[project]
name = "robotframework-jupyterlibrary"
version = "0.5.0a0"
version = "0.5.0a1"
description = "A Robot Framework library for automating (testing of) Jupyter end-user applications and extensions."
readme = "README.md"
authors = [{name = "JupyterLibrary contributors", email = "[email protected]"}]
Expand Down
1 change: 1 addition & 0 deletions src/JupyterLibrary/clients/notebook/Selectors.resource
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ ${JNB CSS CELL} ${JLAB CSS CELL}
${JNB CSS ACCEPT} ${JLAB CSS MOD ACCEPT}

# css selectors
${JNB CSS TREE} .jp-DirListing
${JNB CSS TREE LIST} .jp-DirListing-content
${JNB CSS TREE LIST ITEM} ${JNB CSS TREE LIST} .jp-DirListing-item
${JNB CSS TREE NEW MENU} ${LM CSS MENU}
Expand Down
3 changes: 2 additions & 1 deletion src/JupyterLibrary/clients/notebook/Tree.resource
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ Open Notebook
${final_url} = Set Variable If "${url}" ${url} ${nbserver_url}tree?token=${token}
Open Browser url=${final_url} browser=${browser} &{configuration}
Update Globals For JupyterLab 4
Wait Until Element Is Visible css:${JNB CSS TREE LIST}
Wait Until Element Is Visible css:${JNB CSS TREE}
Wait Until Element Is Visible css:${JNB CSS TREE LIST} timeout=10s

Launch A New Notebook
[Documentation] Use the Jupyter Notebook tree to launch a Notebook with the
Expand Down