Skip to content

Test Python 3.11, jupyter_server 2 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bollwyvl
Copy link
Collaborator

@bollwyvl bollwyvl commented Dec 30, 2022

References

Code changes

  • remove retrolab
  • add py3.11
  • resolve locks
  • add app_class to Build Jupyter Server Arguments
    • add JUPYTER_LIBRARY_APP to overload auto-detection
  • remove quotes from CLI arguments
  • emit the robot log with any FAILs after pabot

User-facing changes

  • ServerApp will be used instead of NotebookApp for any non-jupyter-notebook command
    • the new JUPYTER_LIBRARY_APP environment variable may be specified for more precise control

Backwards-incompatible changes

  • not really, as it was mostly broken

@bollwyvl bollwyvl marked this pull request as ready for review January 1, 2023 15:32
@bollwyvl bollwyvl merged commit 60fcfc6 into robots-from-jupyter:master Jan 1, 2023
@bollwyvl bollwyvl deleted the gh-65-add-jupyter-server-2 branch January 1, 2023 15:32
NON_CRITICAL = [
## Historically supported nteract_on_jupyter
# ["client:nteract_on_jupyter"],
]

PABOT_DEFAULTS = [
"--testlevelsplit",
"--processes",
"4",
*("--processes", "4"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice solution, I've often used --something=else to mitigate the line-split, but not all CLI parsers handles the equal sign.

Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this project @bollwyvl!!

Now depending on this project in jupyterhub/jupyter-server-proxy and seeing great value in its function, I'm interested in learning more about it! So, I figure I'd review this PR to better understand things.

  • Release versioning
    I saw that a feature was added to start_new_jupyter_server, but its not obvious what the next release version should be to me. What do you think about marking next release as 1.0.0? I find going beyond 1.0.0 is a notable improvement help for both maintainers and users in ability to clearly communicate about changes using the version number, and that clarity reduces overall workload.

    How do I know when to release 1.0.0? (from semver.com's FAQ)
    If your software is being used in production, it should probably already be 1.0.0. If you have a stable API on which users have come to depend, you should be 1.0.0. If you’re worrying a lot about backwards compatibility, you should probably already be 1.0.0.

  • What changed - lab1 lab2 but not lab3?
    Looking at the changes, it seems like logic influencing version 1 and 2 of jupyterlab was changed, but probably not jupyterlab 3? I guess that this PR would resolve test failures observer in jupyterhub/jupyter-server-proxy for lab2 tests, but not with lab3.

Thank you once again Nicholas for your work on this project! ❤️ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-run tests to verify function with jupyter_server 2 now released
2 participants