-
Notifications
You must be signed in to change notification settings - Fork 9
Test Python 3.11, jupyter_server 2 #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Python 3.11, jupyter_server 2 #67
Conversation
NON_CRITICAL = [ | ||
## Historically supported nteract_on_jupyter | ||
# ["client:nteract_on_jupyter"], | ||
] | ||
|
||
PABOT_DEFAULTS = [ | ||
"--testlevelsplit", | ||
"--processes", | ||
"4", | ||
*("--processes", "4"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice solution, I've often used --something=else
to mitigate the line-split, but not all CLI parsers handles the equal sign.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this project @bollwyvl!!
Now depending on this project in jupyterhub/jupyter-server-proxy and seeing great value in its function, I'm interested in learning more about it! So, I figure I'd review this PR to better understand things.
-
Release versioning
I saw that a feature was added tostart_new_jupyter_server
, but its not obvious what the next release version should be to me. What do you think about marking next release as 1.0.0? I find going beyond 1.0.0 is a notable improvement help for both maintainers and users in ability to clearly communicate about changes using the version number, and that clarity reduces overall workload.How do I know when to release 1.0.0? (from semver.com's FAQ)
If your software is being used in production, it should probably already be 1.0.0. If you have a stable API on which users have come to depend, you should be 1.0.0. If you’re worrying a lot about backwards compatibility, you should probably already be 1.0.0. -
What changed - lab1 lab2 but not lab3?
Looking at the changes, it seems like logic influencing version 1 and 2 of jupyterlab was changed, but probably not jupyterlab 3? I guess that this PR would resolve test failures observer in jupyterhub/jupyter-server-proxy for lab2 tests, but not with lab3.
Thank you once again Nicholas for your work on this project! ❤️ 🎉
References
Code changes
retrolab
app_class
toBuild Jupyter Server Arguments
JUPYTER_LIBRARY_APP
to overload auto-detectionrobot
log with anyFAIL
s after pabotUser-facing changes
ServerApp
will be used instead ofNotebookApp
for any non-jupyter-notebook
commandJUPYTER_LIBRARY_APP
environment variable may be specified for more precise controlBackwards-incompatible changes