Skip to content

Multiple Dependency Libraries #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

patrick-wolfram
Copy link
Contributor

If multiple downloads are specified in the pyproject.yaml (e.g. [[tool.robotpy-build.wrappers."".download]] is repeated), the first one will create the lib directory where the download's libraries will be extracted to. However, the second will fail because the lib directory already exists. I just modified this to add exist_ok to the os.makedirs call so the second (and third, etc.) can add their libraries as well.

@virtuald
Copy link
Member

Thanks for the fix!

FWIW, I'm in the process of migrating all of the robotpy libraries to a bunch of hatchling plugins and eventually will archive this repo:

  • semiwrap is all the autogeneration code that robotpy-build has, but refactored to use meson+hatchling instead and some of the oddities of robotpy-build have been removed
  • hatch-robotpy does all the download stuff now (and I feel like I ran into this bug there and already fixed it?)

robotpy/mostrobotpy#170 is a PR where I migrated the robotpy core libraries from robotpy-build to semiwrap.

@virtuald virtuald merged commit d68ccde into robotpy:main May 19, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants