Skip to content

Remove pydantic and switch to dataclasses/validobj #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

virtuald
Copy link
Member

@virtuald virtuald commented Mar 2, 2025

Over the years pydantic has annoyed me in various different ways. I'd like to switch to dataclasses, and use validobj for validation instead.

Doing this for the meson rewrite, but interested in feedback.

@virtuald virtuald force-pushed the draft-remove-pydantic branch 3 times, most recently from 5c0f96e to 8570674 Compare March 3, 2025 01:54
@auscompgeek
Copy link
Member

Curious what you find annoying specifically? We've still yet to update to pydantic 2.

@virtuald
Copy link
Member Author

virtuald commented Mar 3, 2025

pydantic has broken at least once or twice over the years, and I feel like there's just been little things that have bubbled up to a general annoyance. I've come to really like dataclasses, so I prefer a solution that can just leverage them. validobj is really simple, and it works.

@virtuald virtuald force-pushed the draft-remove-pydantic branch from 8570674 to 20a5e30 Compare April 3, 2025 04:40
@virtuald virtuald marked this pull request as ready for review May 3, 2025 19:26
@virtuald virtuald force-pushed the draft-remove-pydantic branch from 20a5e30 to 30a9847 Compare May 3, 2025 19:27
@virtuald virtuald merged commit e8d109a into main May 3, 2025
34 checks passed
@virtuald virtuald deleted the draft-remove-pydantic branch May 3, 2025 19:37
@virtuald virtuald mentioned this pull request May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants