Skip to content

Conversation

@jollychang
Copy link
Contributor

for every element find

@j1z0
Copy link
Contributor

j1z0 commented Nov 27, 2012

I do like the idea of adding jQuey support but I have a concern with the way it is implemented in this pull request.
The issue I have has to do with performance. I someone is not using jQuery this incurs and extra round trip for every single element find. This make a big difference in overall performance when using a remote client.

I would rather see an option added to the library init such as UseJquery it should default to false abd only call the jQuery bits if its value is true.

@jollychang
Copy link
Contributor Author

@j1z0 ok,I will try to add as a option

@jollychang
Copy link
Contributor Author

update as options from import Selenium2Library

@ghost ghost assigned j1z0 Dec 11, 2012
@peritus
Copy link
Contributor

peritus commented Jan 18, 2013

I always implement this in "Robot Framework userland":

*** Keywords ***

Wait For Ajax
    Wait for Condition   return window.jQuery.active == 0;

And I think it's better kept that way.

@omahlama
Copy link

omahlama commented Feb 8, 2013

I agree with @peritus, there are cases where you want to do things without waiting for ajax, so the choice should be left to the end user. Maybe documenting this as a typical use scenario would be useful instead.

@peritus
Copy link
Contributor

peritus commented Feb 11, 2013

@omahlama Yes, documentation would be great, also could include examples for all popular Ajax wrapping frameworks!

@emanlove
Copy link
Member

emanlove commented Mar 2, 2013

Consensus seems to be to use a Robot Framework keyword instead of suggested pull request. Added issue #175.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants