-
Notifications
You must be signed in to change notification settings - Fork 90
Added Confidence Argument to keypoint detection model #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Greenstan
wants to merge
6
commits into
roboflow:main
Choose a base branch
from
Greenstan:confidence-to-keypoint-detection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added Confidence Argument to keypoint detection model #354
Greenstan
wants to merge
6
commits into
roboflow:main
from
Greenstan:confidence-to-keypoint-detection
+510
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolomonLake
requested changes
Jun 4, 2025
@@ -0,0 +1,12 @@ | |||
# To get started with Dependabot version updates, you'll need to specify which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this file?
@@ -150,6 +153,7 @@ def __generate_url(self): | |||
self.base_url + without_workspace + "/" + str(version), | |||
"?api_key=" + self.__api_key, | |||
"&name=YOUR_IMAGE.jpg", | |||
f"&confidence={self.confidence}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to want str(self.confidence)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new "Confidence" argument has been added to the keypoint detection model (based on the confidence argument found in the object detection model)
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
A Dedicated keypoint detection model test file has been made with multiple test cases including one where the confidence is changed
Any specific deployment considerations
Docs