starting to add new tests

Author: rnveach

src/test/java/com/gitblit/internal/AbstractServletTest.java

@@ -0,0 +1,28 @@
+package com.gitblit.internal;
+
+import javax.servlet.http.HttpServlet;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+public abstract class AbstractServletTest extends AbstractTest {
+	protected abstract HttpServlet getTestClass();
+
+	protected abstract String getURI();
+
+	protected TestHttpServletRequest createPost() {
+		return new TestHttpServletRequest("POST", getURI());
+	}
+
+	protected TestHttpServletRequest createGet() {
+		return new TestHttpServletRequest("GET", getURI());
+	}
+
+	protected TestHttpServletResponse createResponse() {
+		return new TestHttpServletResponse();
+	}
+
+	protected void doServletService(HttpServletRequest request,
+			HttpServletResponse response) throws Exception {
+		getTestClass().service(request, response);
+	}
+}

src/test/java/com/gitblit/internal/AbstractTest.java

@@ -0,0 +1,13 @@
+package com.gitblit.internal;
+
+import java.io.IOException;
+
+import org.junit.After;
+
+public abstract class AbstractTest {
+	@After
+	public final void cleanUp() throws IOException {
+		GitUtils.clearTempRepositories();
+		TestStoredSettings.clearProperties();
+	}
+}

src/test/java/com/gitblit/internal/GitUtils.java

@@ -0,0 +1,57 @@
+package com.gitblit.internal;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.Collection;
+import java.util.LinkedList;
+
+import org.apache.commons.io.FileUtils;
+import org.eclipse.jgit.api.Git;
+import org.eclipse.jgit.api.errors.GitAPIException;
+import org.eclipse.jgit.lib.Repository;
+import org.eclipse.jgit.storage.file.FileRepositoryBuilder;
+
+public class GitUtils {
+	private static final Collection<Repository> TEMP_REPOSITORIES = new LinkedList<>();
+
+	private GitUtils() {
+	}
+
+	public static Repository createNewRepository() throws IOException {
+		final File repoDir = File.createTempFile("TestTempRepository", "");
+		if (!repoDir.delete()) {
+			throw new IOException("Could not delete temporary file " + repoDir);
+		}
+		final Repository repository = FileRepositoryBuilder.create(new File(
+				repoDir, ".git"));
+		repository.create();
+		TEMP_REPOSITORIES.add(repository);
+		return repository;
+	}
+
+	public static File addAnEmptyFileAndCommit(Repository repository,
+			String fileName) throws IOException, GitAPIException {
+		try (Git git = new Git(repository)) {
+			final File file = new File(repository.getDirectory().getParent(),
+					fileName);
+			if (!file.getParentFile().exists()
+					&& !file.getParentFile().mkdirs()) {
+				throw new IOException("Could not create directory "
+						+ file.getParentFile());
+			}
+			if (!file.createNewFile()) {
+				throw new IOException("Could not create file " + file);
+			}
+			git.add().addFilepattern(fileName).call();
+			git.commit().setMessage("add " + fileName).call();
+			return file;
+		}
+	}
+
+	public static void clearTempRepositories() throws IOException {
+		for (Repository repository : TEMP_REPOSITORIES) {
+			FileUtils
+					.deleteDirectory(repository.getDirectory().getParentFile());
+		}
+	}
+}