Merge pull request #215 from rmrk-team/bug/208-locked-collection-allow-minting-after-burn

fix issue 208 allow minting after burn

Author: ilionic

pallets/rmrk-core/src/functions.rs

@@ -329,7 +329,7 @@ where
 	) -> Result<CollectionId, DispatchError> {
 		Collections::<T>::try_mutate_exists(collection_id, |collection| -> DispatchResult {
 			let collection = collection.as_mut().ok_or(Error::<T>::CollectionUnknown)?;
-			collection.max = Some(collection.nfts_count);
+			collection.max = Some(0);
 			Ok(())
 		})?;
 

pallets/rmrk-core/src/tests.rs

@@ -145,8 +145,8 @@ fn lock_collection_works() {
 		assert_ok!(RMRKCore::burn_nft(Origin::signed(ALICE), COLLECTION_ID_0, NFT_ID_0, MAX_BURNS));
 		// Should now have only three NFTS in collection
 		assert_eq!(RMRKCore::collections(COLLECTION_ID_0).unwrap().nfts_count, 3);
-		// Still we should be unable to mint another NFT
-		assert_ok!(basic_mint(5));
+		// After burning, we should still be unable to mint another NFT
+		assert_noop!(basic_mint(5), Error::<Test>::CollectionFullOrLocked);
 	});
 }
 

tests/src/util/tx.ts

@@ -900,7 +900,7 @@ export async function lockCollection(
 
   await getCollection(api, collectionId).then((collectionOption) => {
     const collection = collectionOption.unwrap();
-    expect(collection.max.unwrap().toNumber()).to.be.equal(max);
+    expect(collection.max.unwrap().toNumber()).to.be.equal(0);
   });
 }