Skip to content

Add support for if/then/else from JSON Schema Draft 7 #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mfulton26 opened this issue Apr 6, 2018 · 3 comments
Closed

Add support for if/then/else from JSON Schema Draft 7 #885

mfulton26 opened this issue Apr 6, 2018 · 3 comments

Comments

@mfulton26
Copy link
Contributor

I recently learned about draft 7 and it's support for if/then/else which seems much easier to reason with than schema dependencies and oneOf (which we added support for not too long ago).

Should there be any concerns about pulling in draft 7 keywords? Does/Can rjsf even use ajv in draft 7 mode? Even if it doesn't/can't (yet) is there any concern about adding support for if/then/else?

Thank you.
@glasserc
Copy link
Contributor

I think we should feel free to use it if we can come up with a good UX for it.

@mfulton26 mfulton26 mentioned this issue May 5, 2018
Closed
9 tasks
qrg added a commit to houkiboshi-fabric/schema that referenced this issue Dec 14, 2018
@qrg
Downgrade JSON Schema to draft-06 from draft-07
e7191e8 
* react-jsonschema-form doesn't support draft-07 yet
  * see.) "Add support for if/then/else from JSON Schema Draft 7"
    * rjsf-team/react-jsonschema-form#885
* VSCode still validates if/then/else correctly
  * not sure why..
qrg added a commit to houkiboshi-fabric/schema that referenced this issue Dec 14, 2018
@qrg
Downgrade JSON Schema to draft-06 from draft-07
5b5a0a3 
* react-jsonschema-form doesn't support draft-07 yet
  * see.) "Add support for if/then/else from JSON Schema Draft 7"
    * rjsf-team/react-jsonschema-form/issues/885
* VSCode still validates if/then/else correctly
  * not sure why..
@epicfaace epicfaace mentioned this issue Apr 17, 2019
Closed
1 task
@epicfaace epicfaace mentioned this issue Nov 21, 2019
Closed
@tarun29061990
Copy link

Hey any update on this?

@epicfaace
Copy link
Member

closing as duplicate of #850

@Saulzi Saulzi mentioned this issue Mar 17, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add initial support for if/then/else and not mfulton26/react-jsonschema-form
4 participants
@glasserc @tarun29061990 @epicfaace @mfulton26