chore: Convert old modules to camelCase and register RuntimeErrors (#52)

Author: Blckbrry-Pi

modules/currency/scripts/set_balance.ts

@@ -14,7 +14,7 @@ export async function run(
 	ctx: ScriptContext,
 	req: Request,
 ): Promise<Response> {
-	await ctx.call("rate_limit", "throttle", { requests: 25 });
+	await ctx.modules.rateLimit.throttle({ requests: 25 });
 
 	if (req.balance < 0) throw new RuntimeError("INVALID_AMOUNT");
 

modules/currency/tests/e2e.ts

@@ -17,7 +17,7 @@ test(
 
 		assertEquals(updatedBalance, 100);
 
-		const { balance: initialBalance } = await ctx.modules.currency.get_balance({
+		const { balance: initialBalance } = await ctx.modules.currency.getBalance({
 			userId: user.id,
 		});
 
@@ -30,14 +30,14 @@ test(
 
 		assertEquals(withdraw, 50);
 
-		const { balance: postWithdrawGetBalance } = await ctx.modules.currency.get_balance({
+		const { balance: postWithdrawGetBalance } = await ctx.modules.currency.getBalance({
 			userId: user.id,
 		});
 
 		assertEquals(postWithdrawGetBalance, 50);
 
-		const { balance } = await ctx.modules.currency.get_balance_by_token({
-			userToken: token,
+		const { balance } = await ctx.modules.currency.getBalanceByToken({
+			userToken: token.token,
 		}) ;
 
 		assertEquals(balance, 50);
@@ -46,19 +46,19 @@ test(
 		assertEquals(postWithdrawGetBalance, balance);
 
 		// set bal to 0
-		await ctx.modules.currency.set_balance({
+		await ctx.modules.currency.setBalance({
 			userId: user.id,
 			balance: 0,
 		});
 
-		const { balance: finalBalance } = await ctx.modules.currency.get_balance({
+		const { balance: finalBalance } = await ctx.modules.currency.getBalance({
 			userId: user.id,
 		});
 
 		assertEquals(finalBalance, 0);
 
-		const { balance: finalBalanceByToken } = await ctx.modules.currency.get_balance_by_token({
-			userToken: token,
+		const { balance: finalBalanceByToken } = await ctx.modules.currency.getBalanceByToken({
+			userToken: token.token,
 		});
 
 		assertEquals(finalBalanceByToken, 0);

modules/currency/utils/set_balance.ts

@@ -1,4 +1,4 @@
-import { prisma } from "../_gen/mod.ts";
+import { RuntimeError, prisma } from "../_gen/mod.ts";
 
 type LimittedDB = Omit<
 	prisma.Prisma.DefaultPrismaClient,
@@ -10,7 +10,7 @@ export const setBalance = async (
 	userId: string,
 	balance: number,
 ) => {
-	if (balance < 0) throw new RangeError("Invalid balance");
+	if (balance < 0) throw new RuntimeError("INVALID_BALANCE");
 
 	await db.userWallet.upsert({
 		where: {

modules/friends/module.yaml

@@ -23,3 +23,4 @@ errors:
   NOT_FRIEND_REQUEST_RECIPIENT: {}
   FRIEND_REQUEST_ALREADY_ACCEPTED: {}
   FRIEND_REQUEST_ALREADY_DECLINED: {}
+  CANNOT_SEND_TO_SELF: {}

modules/friends/scripts/send_request.ts

@@ -21,10 +21,10 @@ export async function run(
 
 	const { userId } = await ctx.call("users", "validate_token", {
 		userToken: req.userToken,
-	}) as any;
+	});
 
 	if (userId === req.targetUserId) {
-		throw new Error("You cannot send a friend request to yourself");
+		throw new RuntimeError("CANNOT_SEND_TO_SELF");
 	}
 
 	// Sort the user IDs to ensure consistency

modules/users/module.yaml

@@ -7,4 +7,6 @@ scripts:
   register:
     public: true
   validate_token: {}
-errors: {}
+errors:
+  TOKEN_NOT_USER_TOKEN: {}
+  UNKNOWN_IDENTITY_TYPE: {}

modules/users/scripts/register.ts

@@ -1,3 +1,4 @@
+import { RuntimeError } from "../_gen/mod.ts";
 import { ScriptContext } from "../_gen/scripts/get.ts";
 import { User } from "../types/common.ts";
 
@@ -37,7 +38,7 @@ export async function run(
 			},
 		};
 	} else {
-		throw new Error("Unknown identity type");
+		throw new RuntimeError("UNKNOWN_IDENTITY_TYPE");
 	}
 
 	// Create user

modules/users/scripts/validate_token.ts

@@ -1,3 +1,4 @@
+import { RuntimeError } from "../_gen/mod.ts";
 import { ScriptContext } from "../_gen/scripts/validate_token.ts";
 
 export interface Request {
@@ -12,10 +13,10 @@ export async function run(
 	ctx: ScriptContext,
 	req: Request,
 ): Promise<Response> {
-	const { token } = await ctx.call("tokens", "validate", {
+	const { token } = await ctx.modules.tokens.validate({
 		token: req.userToken,
-	}) as any;
-	if (token.type !== "user") throw new Error("Token is not a user token");
+	});
+	if (token.type !== "user") throw new RuntimeError("TOKEN_NOT_USER_TOKEN");
 	const userId = token.meta.userId;
 
 	return { userId };