chore: add strict compiler options (#129)

Author: NathanFlurry

deno.json

@@ -0,0 +1,46 @@
+{
+  "tasks": {
+		// Format
+		"format": "deno fmt modules/",
+		"format:check": "deno fmt --check modules/",
+
+		// Check
+		"check": "deno check modules/**/*.ts",
+
+		// Lint
+		"lint": "deno lint modules/",
+		"lint:fix": "deno lint --fix modules/"
+  },
+	"lint": {
+		"include": ["src/"],
+		"exclude": ["tests/"],
+		"rules": {
+			"exclude": ["no-empty-interface", "no-explicit-any", "require-await"]
+		}
+	},
+  "fmt": {
+    "useTabs": true
+  },
+  "compilerOptions": {
+    "strict": true,
+    "noImplicitAny": true,
+    "strictNullChecks": true,
+    "strictFunctionTypes": true,
+    "strictBindCallApply": true,
+    "strictPropertyInitialization": true,
+    "noImplicitThis": true,
+    "useUnknownInCatchVariables": true,
+    "alwaysStrict": true,
+    // "noUnusedLocals": true,
+    // "noUnusedParameters": true,
+    // "exactOptionalPropertyTypes": true,
+    "noImplicitReturns": true,
+    "noFallthroughCasesInSwitch": true,
+    "noUncheckedIndexedAccess": true,
+    "noImplicitOverride": true,
+    // "noPropertyAccessFromIndexSignature": true,
+    "allowUnusedLabels": true,
+    "allowUnreachableCode": true,
+    "noImplicitAny": true
+  }
+}

deno.jsonc

@@ -4,9 +4,7 @@ export interface Config {
 
 export type Provider = { test: ProviderTest } | { sendGrid: ProviderSendGrid };
 
-export interface ProviderTest {
-	// No configuration
-}
+export type ProviderTest = Record<never, never>;
 
 export interface ProviderSendGrid {
 	apiKeyVariable?: string;

modules/email/config.ts

@@ -14,8 +14,7 @@ export interface Request {
 	text?: string;
 }
 
-export interface Response {
-}
+export type Response = Record<never, never>;
 
 export async function run(
 	ctx: ScriptContext,

modules/email/scripts/send_email.ts

@@ -57,7 +57,7 @@ export async function run(
 		}
 
 		// Sort the user IDs to ensure consistency
-		const [userIdA, userIdB] = [
+		const userIds = [
 			friendRequest.senderUserId,
 			friendRequest.targetUserId,
 		].sort();
@@ -70,7 +70,7 @@ export async function run(
 			data: {
 				acceptedAt: new Date(),
 				friend: {
-					create: { userIdA, userIdB },
+					create: { userIdA: userIds[0]!, userIdB: userIds[1]! },
 				},
 			},
 		});

modules/friends/scripts/accept_request.ts

@@ -18,11 +18,11 @@ export async function run(
 	});
 
 	// Sort the user IDs to ensure consistency
-	const [userIdA, userIdB] = [userId, req.targetUserId].sort();
+	const userIds = [userId, req.targetUserId].sort();
 
 	const updated = await ctx.db.friend.update({
 		where: {
-			userIdA_userIdB: { userIdA, userIdB },
+			userIdA_userIdB: { userIdA: userIds[0]!, userIdB: userIds[1]! },
 			removedAt: null,
 		},
 		data: {
@@ -31,7 +31,9 @@ export async function run(
 		select: { userIdA: true, userIdB: true },
 	});
 	if (!updated) {
-		throw new RuntimeError("FRIEND_NOT_FOUND", { meta: { userIdA, userIdB } });
+		throw new RuntimeError("FRIEND_NOT_FOUND", {
+			meta: { userIdA: userIds[0], userIdB: userIds[1] },
+		});
 	}
 
 	return {};

modules/friends/scripts/remove_friend.ts

@@ -52,7 +52,7 @@ function generateToken(type: string): string {
 	// Map to characters
 	let output = "";
 	for (let i = 0; i < buf.length; i++) {
-		output += CHARACTERS[buf[i] % CHARACTERS.length];
+		output += CHARACTERS[buf[i]! % CHARACTERS.length];
 	}
 
 	return `${type}_${output}`;

modules/tokens/scripts/create.ts

@@ -1,4 +1,4 @@
-import { Prisma, ScriptContext } from "../module.gen.ts";
+import { ScriptContext } from "../module.gen.ts";
 
 export interface Request {
 	tokenIds: string[];

modules/tokens/scripts/revoke.ts

@@ -35,7 +35,7 @@ test("e2e", async (ctx: TestContext) => {
 	const getAfterRevoke = await ctx.modules.tokens.fetch({
 		tokenIds: [token.id],
 	});
-	assertExists(getAfterRevoke.tokens[0].revokedAt);
+	assertExists(getAfterRevoke.tokens[0]!.revokedAt);
 
 	const revokeTwiceRes = await ctx.modules.tokens.revoke({
 		tokenIds: [token.id],

modules/tokens/tests/e2e.ts

@@ -34,7 +34,7 @@ test("e2e", async (ctx: TestContext) => {
 
 	// Upload the data using the presigned URL(s) returned
 	const uploadPutReq = await fetch(
-		presigned.files[0].presignedChunks[0].url,
+		presigned.files[0]!.presignedChunks[0]!.url,
 		{
 			method: "PUT",
 			body: fileData,
@@ -77,10 +77,11 @@ test("e2e", async (ctx: TestContext) => {
 	assertEquals(completed, retrieved);
 
 	// Get presigned URLs to download the files from
-	const { files: [{ url: fileDownloadUrl }] } = await ctx.modules.uploads
+	const { files } = await ctx.modules.uploads
 		.getPublicFileUrls({
 			files: [{ uploadId: completed.id, path: path }],
 		});
+	const fileDownloadUrl = files[0]!.url;
 
 	// Download the files, and make sure the data matches
 	const fileDownloadReq = await fetch(fileDownloadUrl);