Skip to content

use Link component on QueueList page, not raw <a> tag #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgentry merged 1 commit into from
May 11, 2025
Merged

use Link component on QueueList page, not raw <a> tag #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Job args and metadata on the job detail view now use an interactive collapsible JSON view rather than pretty-printing the entire payload on screen. For large payloads this is a better UX and doesn't disrupt the page flow by default. [PR #351](https://github.com/riverqueue/riverui/pull/351).

### Fixed

- Corrected links on queue list page to use the TanStack Router `<Link>` component instead of raw `<a>` tags so that settings like path prefix will be respected. [PR #353](https://github.com/riverqueue/riverui/pull/353).

## [v0.9.0] - 2025-04-08

### Added
Expand Down
8 changes: 5 additions & 3 deletions src/components/QueueList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import RelativeTimeFormatter from "@components/RelativeTimeFormatter";
import TopNavTitleOnly from "@components/TopNavTitleOnly";
import { PauseCircleIcon, PlayCircleIcon } from "@heroicons/react/24/outline";
import { Queue } from "@services/queues";
import { Link } from "@tanstack/react-router";

type QueueListProps = {
loading: boolean;
Expand Down Expand Up @@ -72,12 +73,13 @@ const QueueList = ({
<tr key={queue.name}>
<td className="w-full max-w-0 py-2 pr-3 pl-4 text-sm font-medium text-slate-700 sm:w-auto sm:max-w-none sm:pl-0 dark:text-slate-300">
<span className="font-mono font-semibold dark:text-slate-100">
<a
<Link
className="text-slate-900 dark:text-slate-200"
href={`/queues/${queue.name}`}
params={{ name: queue.name }}
to="/queues/$name"
>
{queue.name}
</a>
</Link>
</span>
<dl className="font-normal md:hidden">
<dt className="sr-only sm:hidden">Available</dt>
Expand Down
Loading