Some more tweaks for query encoding but it still doesn't seem to work on .NET 4.8

Author: alexeyzimarev

src/RestSharp/Request/Parsers.cs

@@ -0,0 +1,60 @@
+// Copyright (c) .NET Foundation and Contributors
+// 
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// 
+// http://www.apache.org/licenses/LICENSE-2.0
+// 
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+using System.Text;
+using System.Web;
+
+namespace RestSharp;
+
+static class Parsers {
+    // ReSharper disable once CognitiveComplexity
+    public static IEnumerable<KeyValuePair<string, string?>> ParseQueryString(string query, Encoding encoding) {
+        Ensure.NotNull(query, nameof(query));
+        Ensure.NotNull(encoding, nameof(encoding));
+        var length      = query.Length;
+        var startIndex1 = query[0] == '?' ? 1 : 0;
+
+        if (length == startIndex1)
+            yield break;
+
+        while (startIndex1 <= length) {
+            var startIndex2 = -1;
+            var num         = -1;
+
+            for (var index = startIndex1; index < length; ++index) {
+                if (startIndex2 == -1 && query[index] == '=')
+                    startIndex2 = index + 1;
+                else if (query[index] == '&') {
+                    num = index;
+                    break;
+                }
+            }
+
+            string? name;
+
+            if (startIndex2 == -1) {
+                name        = null;
+                startIndex2 = startIndex1;
+            }
+            else
+                name = HttpUtility.UrlDecode(query.Substring(startIndex1, startIndex2 - startIndex1 - 1), encoding);
+
+            if (num < 0)
+                num = query.Length;
+            startIndex1 = num + 1;
+            var str = HttpUtility.UrlDecode(query.Substring(startIndex2, num - startIndex2), encoding);
+            yield return new KeyValuePair<string, string?>(name ?? "", str);
+        }
+    }
+}

src/RestSharp/Request/RestRequest.cs

@@ -13,6 +13,8 @@
 // limitations under the License.
 
 using System.Net.Http.Headers;
+using System.Text;
+using System.Web;
 
 // ReSharper disable ReplaceSubstringWithRangeIndexer
 // ReSharper disable UnusedAutoPropertyAccessor.Global
@@ -39,35 +41,30 @@ public class RestRequest {
     /// Constructor for a rest request to a relative resource URL and optional method
     /// </summary>
     /// <param name="resource">Resource to use</param>
-    /// <param name="method">Method to use (defaults to Method.Get></param>
+    /// <param name="method">Method to use. Default is Method.Get.</param>
     public RestRequest(string? resource, Method method = Method.Get) : this() {
         Resource = resource ?? "";
-        Method   = method;
+        Method = method;
 
-        if (string.IsNullOrWhiteSpace(resource)) return;
+        if (string.IsNullOrWhiteSpace(resource)) {
+            Resource = "";
+            return;
+        }
 
         var queryStringStart = Resource.IndexOf('?');
 
-        if (queryStringStart < 0 || Resource.IndexOf('=') <= queryStringStart) return;
+        if (queryStringStart < 0 || Resource.IndexOf('=') <= queryStringStart) {
+            return;
+        }
 
-        var queryParams = ParseQuery(Resource.Substring(queryStringStart + 1));
+        var queryString = Resource.Substring(queryStringStart + 1);
         Resource = Resource.Substring(0, queryStringStart);
 
-        foreach (var param in queryParams) this.AddQueryParameter(param.Key, param.Value);
-
-        return;
+        var queryParameters = Parsers.ParseQueryString(queryString, Encoding.UTF8);
 
-        static IEnumerable<KeyValuePair<string, string?>> ParseQuery(string query)
-            => query.Split(new[] { '&' }, StringSplitOptions.RemoveEmptyEntries)
-                .Select(
-                    x => {
-                        var position = x.IndexOf('=');
-
-                        return position > 0
-                            ? new KeyValuePair<string, string?>(x.Substring(0, position), x.Substring(position + 1))
-                            : new KeyValuePair<string, string?>(x, null);
-                    }
-                );
+        foreach (var parameter in queryParameters) {
+            this.AddQueryParameter(parameter.Key, parameter.Value);
+        }
     }
 
     /// <summary>

src/RestSharp/Request/UriExtensions.cs

@@ -18,20 +18,44 @@
 namespace RestSharp;
 
 static class UriExtensions {
+#if NET6_0_OR_GREATER
+    internal static UriCreationOptions UriOptions = new() { DangerousDisablePathAndQueryCanonicalization = true };
+#endif
+
     public static Uri MergeBaseUrlAndResource(this Uri? baseUrl, string? resource) {
         var assembled = resource;
 
+#if NET6_0_OR_GREATER
+        if (assembled.IsNotEmpty() && assembled.StartsWith('/')) assembled = assembled[1..];
+#else
         if (assembled.IsNotEmpty() && assembled.StartsWith("/")) assembled = assembled.Substring(1);
+#endif
 
         if (baseUrl == null || baseUrl.AbsoluteUri.IsEmpty()) {
             return assembled.IsNotEmpty()
-                ? new Uri(assembled)
+#if NET6_0_OR_GREATER
+                ? new Uri(assembled, UriOptions)
+#else
+                ? new Uri(assembled, false)
+#endif
                 : throw new ArgumentException("Both BaseUrl and Resource are empty", nameof(resource));
         }
 
-        var usingBaseUri = baseUrl.AbsoluteUri.EndsWith("/") || assembled.IsEmpty() ? baseUrl : new Uri($"{baseUrl.AbsoluteUri}/");
+#if NET6_0_OR_GREATER
+        var usingBaseUri = baseUrl.AbsoluteUri.EndsWith('/') || assembled.IsEmpty() ? baseUrl : new Uri($"{baseUrl.AbsoluteUri}/", UriOptions);
 
-        return assembled != null ? new Uri(usingBaseUri, assembled) : baseUrl;
+        var isResourceAbsolute = false;
+        // ReSharper disable once InvertIf
+        if (assembled != null) {
+            var resourceUri = new Uri(assembled, UriKind.RelativeOrAbsolute);
+            isResourceAbsolute = resourceUri.IsAbsoluteUri;
+        }
+
+        return assembled != null ? new Uri(isResourceAbsolute ? assembled : $"{usingBaseUri.AbsoluteUri}{assembled}", UriOptions) : baseUrl;
+#else
+        var usingBaseUri = baseUrl.AbsoluteUri.EndsWith("/") || assembled.IsEmpty() ? baseUrl : new Uri($"{baseUrl.AbsoluteUri}/", false);
+        return assembled != null ? new Uri(usingBaseUri, assembled, false) : baseUrl;
+#endif
     }
 
     public static Uri AddQueryString(this Uri uri, string? query) {
@@ -40,9 +64,9 @@ public static Uri AddQueryString(this Uri uri, string? query) {
         var absoluteUri = uri.AbsoluteUri;
         var separator   = absoluteUri.Contains('?') ? "&" : "?";
 
-        var result = 
+        var result =
 #if NET6_0_OR_GREATER
-            new Uri($"{absoluteUri}{separator}{query}", new UriCreationOptions{DangerousDisablePathAndQueryCanonicalization = true});
+            new Uri($"{absoluteUri}{separator}{query}", new UriCreationOptions { DangerousDisablePathAndQueryCanonicalization = true });
 #else
 #pragma warning disable CS0618 // Type or member is obsolete
             new Uri($"{absoluteUri}{separator}{query}", false);

test/RestSharp.Tests.Integrated/ResourceStringParametersTests.cs

@@ -20,6 +20,8 @@ public async Task Should_keep_to_parameters_with_the_same_name() {
         using var client  = new RestClient(_server.Url!);
         var request = new RestRequest(parameters);
 
+        var uri = client.BuildUri(request);
+
         await client.GetAsync(request);
 
         var query = new Uri(url).Query;

test/RestSharp.Tests/ParametersTests.cs

@@ -44,7 +44,7 @@ public void AddUrlSegmentModifiesUrlSegmentWithInt() {
         using var client = new RestClient(BaseUrl);
         var       actual = client.BuildUri(request).AbsolutePath;
 
-        expected.Should().BeEquivalentTo(actual);
+        actual.Should().Be(expected);
     }
 
     [Fact]

test/RestSharp.Tests/RestClientTests.cs

@@ -32,38 +32,6 @@ public async Task ConfigureHttp_will_set_proxy_to_null_with_no_exceptions_When_n
         await client.ExecuteAsync(req);
     }
 
-    [Fact]
-    public void BuildUri_should_build_with_passing_link_as_Uri() {
-        // arrange
-        var relative    = new Uri("/foo/bar/baz", UriKind.Relative);
-        var absoluteUri = new Uri(new Uri(BaseUrl), relative);
-        var req         = new RestRequest(absoluteUri);
-
-        // act
-        using var client = new RestClient();
-
-        var builtUri = client.BuildUri(req);
-
-        // assert
-        absoluteUri.Should().Be(builtUri);
-    }
-
-    [Fact]
-    public void BuildUri_should_build_with_passing_link_as_Uri_with_set_BaseUrl() {
-        // arrange
-        var baseUrl  = new Uri(BaseUrl);
-        var relative = new Uri("/foo/bar/baz", UriKind.Relative);
-        var req      = new RestRequest(relative);
-
-        // act
-        using var client = new RestClient(baseUrl);
-
-        var builtUri = client.BuildUri(req);
-
-        // assert
-        new Uri(baseUrl, relative).Should().Be(builtUri);
-    }
-
     [Fact]
     public void UseJson_leaves_only_json_serializer() {
         // arrange

test/RestSharp.Tests/RestRequestTests.cs

@@ -9,17 +9,26 @@ public void RestRequest_Request_Property() {
 
     [Fact]
     public void RestRequest_Test_Already_Encoded() {
-        var request    = new RestRequest("/api/get?query=Id%3d198&another=notencoded");
+        const string resource = "/api/get?query=Id%3d198&another=notencoded&novalue=";
+        const string baseUrl  = "https://example.com";
+        
+        var request    = new RestRequest(resource);
         var parameters = request.Parameters.ToArray();
 
         request.Resource.Should().Be("/api/get");
-        parameters.Length.Should().Be(2);
+        parameters.Length.Should().Be(3);
 
         var expected = new[] {
             new { Name = "query", Value   = "Id%3d198", Type   = ParameterType.QueryString, Encode = false },
-            new { Name = "another", Value = "notencoded", Type = ParameterType.QueryString, Encode = false }
+            new { Name = "another", Value = "notencoded", Type = ParameterType.QueryString, Encode = false },
+            new { Name = "novalue", Value = "", Type = ParameterType.QueryString, Encode = false }
         };
-        parameters.Should().BeEquivalentTo(expected, options => options.ExcludingMissingMembers());
+        // parameters.Should().BeEquivalentTo(expected, options => options.ExcludingMissingMembers());
+
+        using var client = new RestClient(baseUrl);
+
+        var actual = client.BuildUri(request);
+        actual.AbsoluteUri.Should().Be($"{baseUrl}{resource}");
     }
 
     [Fact]

test/RestSharp.Tests/UrlBuilderTests.cs

@@ -21,13 +21,13 @@ public void GET_with_empty_base_and_resource_containing_tokens() {
 
     [Fact]
     public void GET_with_empty_request() {
-        var request  = new RestRequest();
+        var request = new RestRequest();
         AssertUri("http://example.com", request, "http://example.com/");
     }
 
     [Fact]
     public void GET_with_empty_request_and_bare_hostname() {
-        var request  = new RestRequest();
+        var request = new RestRequest();
         AssertUri("http://example.com", request, "http://example.com/");
     }
 
@@ -173,8 +173,12 @@ public void Should_build_uri_using_selected_encoding() {
         // utf-8 and iso-8859-1
         var request = new RestRequest().AddOrUpdateParameter("town", "Hillerød");
 
-        const string expectedDefaultEncoding  = "http://example.com/resource?town=Hiller%c3%b8d";
         const string expectedIso89591Encoding = "http://example.com/resource?town=Hiller%f8d";
+#if NET6_0_OR_GREATER
+        const string expectedDefaultEncoding = "http://example.com/resource?town=Hiller%c3%b8d";
+#else
+        const string expectedDefaultEncoding = "http://example.com/resource?town=Hiller%C3%B8d";
+#endif
 
         AssertUri("http://example.com/resource", request, expectedDefaultEncoding);
 
@@ -236,13 +240,37 @@ public void Should_use_ipv6_address() {
         actual.AbsoluteUri.Should().Be("https://[fe80::290:e8ff:fe8b:2537]:8443/api/v1/auth");
     }
 
+    const string BaseUrl = "http://localhost:8888/";
+
+    [Fact]
+    public void Should_build_with_passing_link_as_Uri() {
+        var relative    = new Uri("/foo/bar/baz", UriKind.Relative);
+        var absoluteUri = new Uri(new Uri(BaseUrl), relative);
+        var req         = new RestRequest(absoluteUri);
+
+        AssertUri(req, absoluteUri.AbsoluteUri);
+    }
+
+    [Fact]
+    public void Should_build_with_passing_link_as_Uri_with_set_BaseUrl() {
+        var baseUrl  = new Uri(BaseUrl);
+        var relative = new Uri("/foo/bar/baz", UriKind.Relative);
+        var req      = new RestRequest(relative);
+
+        using var client = new RestClient(baseUrl);
+
+        var builtUri = client.BuildUri(req);
+
+        AssertUri(BaseUrl, req, builtUri.AbsoluteUri);
+    }
+
     [Fact]
     public void Should_encode_resource() {
-        const string baseUrl = "https://example.com";
+        const string baseUrl  = "https://example.com";
         const string resource = "resource?param=value with spaces";
 
         var request = new RestRequest(resource);
-        var uri = new Uri($"{baseUrl}/{resource}");
+        var uri     = new Uri($"{baseUrl}/{resource}");
         AssertUri(baseUrl, request, uri.AbsoluteUri);
     }