fix more lint

Signed-off-by: Nik Nasr <[email protected]>

Author: nikrooz

eslint.config.js

@@ -47,11 +47,6 @@ export default [
         "error",
         { allowInterfaces: "always" },
       ],
-      "@typescript-eslint/require-await": "off",
-      "@typescript-eslint/no-floating-promises": "off",
-      "@typescript-eslint/no-duplicate-type-constituents": "off",
-      "@typescript-eslint/only-throw-error": "off",
-      "@typescript-eslint/no-empty-function": "off",
       "@typescript-eslint/restrict-template-expressions": [
         "error",
         {
@@ -70,6 +65,8 @@ export default [
     ],
     rules: {
       "no-console": "off",
+      "@typescript-eslint/require-await": "off",
+      "@typescript-eslint/no-floating-promises": "off",
     },
   },
   {

packages/restate-sdk-clients/src/ingress.ts

@@ -414,7 +414,7 @@ class HttpIngress implements Ingress {
 
   async resolveAwakeable<T>(
     id: string,
-    payload?: T | undefined,
+    payload?: T  ,
     payloadSerde?: Serde<T>
   ): Promise<void> {
     const url = `${this.opts.url}/restate/a/${id}/resolve`;

packages/restate-sdk/src/context_impl.ts

@@ -817,28 +817,19 @@ class DurablePromiseImpl<T> implements DurablePromise<T> {
   }
 
   then<TResult1 = T, TResult2 = never>(
-    onfulfilled?:
-      | ((value: T) => TResult1 | PromiseLike<TResult1>)
-      | null
-      | undefined,
-    onrejected?:
-      | ((reason: any) => TResult2 | PromiseLike<TResult2>)
-      | null
-      | undefined
+    onfulfilled?: ((value: T) => TResult1 | PromiseLike<TResult1>) | null,
+    onrejected?: ((reason: any) => TResult2 | PromiseLike<TResult2>) | null
   ): Promise<TResult1 | TResult2> {
     return this.get().then(onfulfilled, onrejected);
   }
 
   catch<TResult = never>(
-    onrejected?:
-      | ((reason: any) => TResult | PromiseLike<TResult>)
-      | null
-      | undefined
+    onrejected?: ((reason: any) => TResult | PromiseLike<TResult>) | null
   ): Promise<T | TResult> {
     return this.get().catch(onrejected);
   }
 
-  finally(onfinally?: (() => void) | null | undefined): Promise<T> {
+  finally(onfinally?: (() => void) | null): Promise<T> {
     return this.get().finally(onfinally);
   }
 
@@ -865,7 +856,7 @@ class DurablePromiseImpl<T> implements DurablePromise<T> {
     );
   }
 
-  resolve(value?: T | undefined): Promise<void> {
+  resolve(value?: T): Promise<void> {
     return this.ctx.processCompletableEntry(
       WasmCommandType.CompletePromise,
       () => this.ctx.journalValueCodec.encode(this.serde.serialize(value as T)),
@@ -959,6 +950,7 @@ function completeCommandPromiseUsing<T>(
         }
       }
     } catch (e) {
+      // eslint-disable-next-line @typescript-eslint/only-throw-error
       throw new AsyncCompleterError(e, commandType, commandIndex);
     }
 

packages/restate-sdk/src/promises.ts

@@ -81,11 +81,11 @@ abstract class AbstractRestatePromise<T> implements InternalRestatePromise<T> {
     onfulfilled?:
       | ((value: T) => TResult1 | PromiseLike<TResult1>)
       | null
-      | undefined,
+       ,
     onrejected?:
       | ((reason: any) => TResult2 | PromiseLike<TResult2>)
       | null
-      | undefined
+       
   ): Promise<TResult1 | TResult2> {
     this.pollingPromise =
       this.pollingPromise ||
@@ -99,7 +99,7 @@ abstract class AbstractRestatePromise<T> implements InternalRestatePromise<T> {
     onrejected?:
       | ((reason: any) => TResult | PromiseLike<TResult>)
       | null
-      | undefined
+       
   ): Promise<T | TResult> {
     this.pollingPromise =
       this.pollingPromise ||
@@ -109,7 +109,7 @@ abstract class AbstractRestatePromise<T> implements InternalRestatePromise<T> {
     return this.publicPromiseOrCancelPromise().catch(onrejected);
   }
 
-  finally(onfinally?: (() => void) | null | undefined): Promise<T> {
+  finally(onfinally?: (() => void) | null  ): Promise<T> {
     this.pollingPromise =
       this.pollingPromise ||
       this[RESTATE_CTX_SYMBOL].promisesExecutor
@@ -270,11 +270,11 @@ export class RestatePendingPromise<T> implements InternalRestatePromise<T> {
     onfulfilled?:
       | ((value: T) => TResult1 | PromiseLike<TResult1>)
       | null
-      | undefined,
+       ,
     onrejected?:
       | ((reason: any) => TResult2 | PromiseLike<TResult2>)
       | null
-      | undefined
+       
   ): Promise<TResult1 | TResult2> {
     return pendingPromise<T>().then(onfulfilled, onrejected);
   }
@@ -283,12 +283,12 @@ export class RestatePendingPromise<T> implements InternalRestatePromise<T> {
     onrejected?:
       | ((reason: any) => TResult | PromiseLike<TResult>)
       | null
-      | undefined
+       
   ): Promise<T | TResult> {
     return pendingPromise<T>().catch(onrejected);
   }
 
-  finally(onfinally?: (() => void) | null | undefined): Promise<T> {
+  finally(onfinally?: (() => void) | null  ): Promise<T> {
     return pendingPromise<T>().finally(onfinally);
   }