This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Dropped annotations from punned record labels. #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
annotate-record-field
branch
from
5b60f01 to
d76a32f
Compare
cristianoc
commented
Jun 27, 2022
| @@ -2674,6 +2676,7 @@ and parseJsxChildren p = | |||
| and parseBracedOrRecordExpr p = | |||
| let startPos = p.Parser.startPos in | |||
| Parser.expect Lbrace p; | |||
| let attrsForFields = parseAttributesForFields p in | |||
There was a problem hiding this comment.
This is very close to surface syntax.
cristianoc
force-pushed
the
annotate-record-field
branch
from
e8aa6b0 to
949a7b9
Compare
| @@ -6250,9 +6263,29 @@ and parseAttribute p = | |||
| ] ) | |||
| | _ -> None | |||
|
|
|||
| and parseAttributeForFields p = | |||
| let isAttributeForField p = | |||
| Parser.lookahead p (function state -> | |||
There was a problem hiding this comment.
I guess the grammar forces us into using a lookahead?
There was a problem hiding this comment.
It's super overloaded over there. Apparently {JSX stufff} only works because the JSX attribute drives the parser into a specific path (which does not consider records). Which itself is arbitrary.
I'm thinking of considering proper surface syntax early on, so one does not need to distinguish based on the name of attributes, which is really not robust.
There was a problem hiding this comment.
Before this PR, it already distinguished based on the presence of attributes, which is also unclear whether intended.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add examples of expression and patterns showing where they are dropped.
Support all the cases discussed in #583