This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Parse <Foo.bar /> elements #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +20,7 @@ let _ = <div className="menu" onClick={_ => Js.log("click")}></div> | |||
|
|
|||
| let _ = <Navbar> </Navbar> | |||
| let _ = <Nav.Navbar> </Nav.Navbar> | |||
| let _ = <Nav.navbar> </Nav.navbar> | |||
There was a problem hiding this comment.
Can you add more test cases? Nested, self closing etc.
Can you also test cases for the printer in tests/printer/expr/jsx.js?
Can you also add a test case in tests/parsing/errors/expression/jsx with an error in the closing "name"?
<Nav.navbar> </Nav.foo>?
There was a problem hiding this comment.
Thanks @IwanKaramazow, added in 6987427.
|
@jchavarri Muchas gracias! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in #124.
Reason parser used to parse JSX elements like
<Foo.bar />:https://astexplorer.net/#/gist/e21abaf96358b68be3ed3da19930be58/32e083720817c639502960b54984dff8396a3f7b.
React ppx also builds on top of this to allow custom
makenames, e.g.is transformed into:
(shameless plug, can be tested in https://jchavarri.github.io/ppx-explorer/ 😜 )