This repository was archived by the owner on Jun 15, 2023. It is now read-only.
object method call simplification #311
Comments
|
What happens to Edit: seems mixing the two causes an assertion error:
|
|
This is not finished yet. currently you use |
|
@chenglou The error is fixed in rescript-lang/rescript#4986. So we can simplify the method call in ReScript syntax now. |
IwanKaramazow
pushed a commit
that referenced
this issue
Mar 25, 2021
Fixes #311 `obj["say"]` was currently parsed as `obj##say` (Pexp_apply with ##) We now parse this straight into `obj#say`(Pexp_send)
IwanKaramazow
pushed a commit
that referenced
this issue
Mar 25, 2021
Fixes #311 `obj["say"]` was currently parsed as `obj##say` (Pexp_apply with ##) We now parse this straight into `obj#say`(Pexp_send)
IwanKaramazow
pushed a commit
that referenced
this issue
Mar 25, 2021
Fixes #311 `obj["say"]` was currently parsed as `obj##say` (Pexp_apply with ##) We now parse this straight into `obj#say`(Pexp_send)
IwanKaramazow
added a commit
that referenced
this issue
Mar 25, 2021
Fixes #311 `obj["say"]` was currently parsed as `obj##say` (Pexp_apply with ##) We now parse this straight into `obj#say`(Pexp_send) Co-authored-by: Iwan <[email protected]>
kevinbarabash
pushed a commit
to kevinbarabash/rescript-compiler
that referenced
this issue
Dec 24, 2021
…g#348) Fixes rescript-lang/syntax#311 `obj["say"]` was currently parsed as `obj##say` (Pexp_apply with ##) We now parse this straight into `obj#say`(Pexp_send) Co-authored-by: Iwan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Thanks to the recent clean up, there is no need to apply a ppx for method call.
obj["say"]was currently compiled intoobj##say, and transformed again in the compiler into Pexp_send with some wrappers.This is not needed any more, it can be translated into
obj#saywithout any post-processing.To finish this, we should also implement the printer logic for
Pexp_sendThe text was updated successfully, but these errors were encountered: