Skip to content

Export bins from package #7530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented May 27, 2025

This is convenient to have.

@nojaf nojaf requested a review from cometkim May 27, 2025 16:49
Copy link

pkg-pr-new bot commented May 27, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7530

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7530

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7530

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7530

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7530

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7530

commit: 0b047ad

@cometkim
Copy link
Member

What's this?

@cometkim
Copy link
Member

cometkim commented May 28, 2025

I intentionally did not export this because I do not want to make it a public API yet. If we exported this, it would be the first compiler API surface. Then we need to discuss its shape more carefully.

@nojaf
Copy link
Collaborator Author

nojaf commented May 28, 2025

That is why I marked the changelog entry as internal.

I've used the trick mentioned here a few times, and it would be more convenient to have this without the dynamic import.

I believe we don't need to finalize the entire compiler API to export some binary paths. This is an internal, undocumented API with no guarantees.

@cknitt
Copy link
Member

cknitt commented Jun 2, 2025

I am also a bit hesitant about exporting this. I am afraid that as soon as it's there, people will start abusing it.

Even though undocumented, it's not really clear from the name "binaries" that this is internal API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants