-
Notifications
You must be signed in to change notification settings - Fork 470
Add Iterator.prototype bindings #7506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nojaf
wants to merge
12
commits into
rescript-lang:master
Choose a base branch
from
nojaf:iterator-bindings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
63ba4a3
Add Iterator.prototype bindings
nojaf 9499875
Fix tests
nojaf 273219e
Polyfill `Iterator.prototype.forEach` for node 20
nojaf c40bf36
Polyfill iterator
nojaf 23d80f9
Use assertEqual instead of Console.log
nojaf 229538d
Revert iterator polyfill
nojaf 98b4563
Use node 22 for dev
nojaf d95d4ef
Update .github/workflows/ci.yml
nojaf 118a9e0
Revert Core_TempTests.res
nojaf 4b56a1b
Remove import from compiled js
nojaf 52bef1b
Add changelog entries
nojaf bfeb70f
Merge branch 'master' into iterator-bindings
nojaf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
20 | ||
22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1 @@ | ||
|
||
|
||
|
||
function forEach(iterator, f) { | ||
let iteratorDone = false; | ||
while (!iteratorDone) { | ||
let match = iterator.next(); | ||
f(match.value); | ||
iteratorDone = match.done; | ||
}; | ||
} | ||
|
||
export { | ||
forEach, | ||
} | ||
/* No side effect */ | ||
/* This output is empty. Its source's type definitions, externals and/or unused code got optimized away. */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1 @@ | ||
'use strict'; | ||
|
||
|
||
function forEach(iterator, f) { | ||
let iteratorDone = false; | ||
while (!iteratorDone) { | ||
let match = iterator.next(); | ||
f(match.value); | ||
iteratorDone = match.done; | ||
}; | ||
} | ||
|
||
exports.forEach = forEach; | ||
/* No side effect */ | ||
/* This output is empty. Its source's type definitions, externals and/or unused code got optimized away. */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,17 +7,38 @@ type value<'a> = { | |
} | ||
|
||
@send external next: t<'a> => value<'a> = "next" | ||
external toArray: t<'a> => array<'a> = "Array.from" | ||
@send | ||
external toArray: t<'a> => array<'a> = "toArray" | ||
external toArrayWithMapper: (t<'a>, 'a => 'b) => array<'b> = "Array.from" | ||
|
||
let forEach = (iterator, f) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm for this change 👍
|
||
let iteratorDone = ref(false) | ||
|
||
while !iteratorDone.contents { | ||
let {done, value} = iterator->next | ||
f(value) | ||
iteratorDone := done | ||
} | ||
} | ||
@send | ||
external forEach: (t<'a>, 'a => unit) => unit = "forEach" | ||
|
||
external ignore: t<'a> => unit = "%ignore" | ||
|
||
@send | ||
external drop: (t<'a>, int) => t<'a> = "drop" | ||
|
||
@send | ||
external every: (t<'a>, 'a => bool) => bool = "every" | ||
|
||
@send | ||
external filter: (t<'a>, 'a => bool) => t<'a> = "filter" | ||
|
||
@send | ||
external find: (t<'a>, 'a => bool) => option<'a> = "find" | ||
|
||
@send | ||
external flatMap: (t<'a>, 'a => t<'b>) => t<'b> = "flatMap" | ||
|
||
@send | ||
external map: (t<'a>, 'a => 'b) => t<'b> = "map" | ||
|
||
@send | ||
external reduce: (t<'a>, ('acc, 'a) => 'acc, ~initialValue: 'acc=?) => 'acc = "reduce" | ||
|
||
@send | ||
external some: (t<'a>, 'a => bool) => bool = "some" | ||
|
||
@send | ||
external take: (t<'a>, int) => t<'a> = "take" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.