Fix crash in "rescript build" on Windows and add test #5516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
force-pushed
the
test-rescript-not-bsc
branch
2 times, most recently
from
e96c3ab to
ad5d1ed
Compare
cknitt
force-pushed
the
test-rescript-not-bsc
branch
from
ad5d1ed to
e02e3c7
Compare
cknitt
changed the title
cknitt
changed the title
cristianoc
approved these changes
Jul 9, 2022
| @@ -3,6 +3,7 @@ | |||
| #include <string.h> | |||
| #include <stdint.h> | |||
| #include "caml/memory.h" | |||
| #include "caml/osdeps.h" | |||
There was a problem hiding this comment.
Any idea of what happened?
Was this removed or was it never there?
There was a problem hiding this comment.
In 9.1.4, this wasn't there either, but
ret = CAML_SYS_STAT(p, &st);was used instead of
ret = stat_os(p, &st);There was a problem hiding this comment.
(Now CAML_SYS_STAT does not exist anymore, this was probably an OCaml 4.06 thing?)
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5517 and tests
rescript buildwith finished package on each platform.(Adding
in
jscomp/stubs/ext_basic_hash_stubs.cfixes compiler warnings and the crash inrescript buildon Windows.)