Skip to content

Update artifacts.json #5475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jun 26, 2022

  • Updated .npmignore and added some files that should not go into the finished npm package.
  • Added missing darwinarm64/ninja.COPYING.
  • Ran prepublish.sh to update artifacts.json.

@cristianoc Please check the changes in artifacts.json. The contents of artifacts.json is exactly what would go into the finished npm package when publishing.

@cknitt cknitt force-pushed the update-artifacts-json branch from 54929b2 to 0fd8bb0 Compare June 27, 2022 04:42
@cknitt cknitt changed the title Run prepublish.sh to update artifacts.json Update artifacts.json Jun 27, 2022
@cknitt cknitt marked this pull request as ready for review June 27, 2022 05:29
@cknitt cknitt requested a review from cristianoc June 27, 2022 05:29
@cristianoc
Copy link
Collaborator

This list is very useful!
Would you update #5413 using this info? Eventually it needs to turn into docs for breaking changes.

@cknitt cknitt merged commit fd2290b into rescript-lang:master Jun 27, 2022
@cknitt cknitt deleted the update-artifacts-json branch June 27, 2022 07:18
@cknitt
Copy link
Member Author

cknitt commented Jun 27, 2022

Updated #5413.

mununki pushed a commit to mununki/rescript-compiler that referenced this pull request Jul 15, 2022
* Add ninja.COPYING to darwinarm64 dir

* Update .npmignore

* Run prepublish.sh to update artifacts.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants