Skip to content

try to preserve local function names for better stack trace #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bobzhang opened this issue May 5, 2016 · 1 comment
Closed

try to preserve local function names for better stack trace #348

bobzhang opened this issue May 5, 2016 · 1 comment
Labels
enhancement stale Old issues that went stale

Comments

@bobzhang
Copy link
Member

bobzhang commented May 5, 2016

let g y =
  let h x = x + y 
  in  h

generated code:

function g(y) {
  return function (x) {
    return x + y | 0;
  };
}

it would better to have

function g(y) {
  return function h(x) {
    return x + y | 0;
  };
}
@bobzhang bobzhang added this to the future- milestone May 23, 2016
@bobzhang bobzhang removed this from the after-4.04 milestone Aug 28, 2017
kevinbarabash pushed a commit to kevinbarabash/rescript-compiler that referenced this issue Dec 24, 2021
…g#348)

Fixes rescript-lang/syntax#311

`obj["say"]` was currently parsed as `obj##say` (Pexp_apply with ##)
We now parse this straight into `obj#say`(Pexp_send)

Co-authored-by: Iwan <[email protected]>
@stale
Copy link

stale bot commented May 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Old issues that went stale label May 9, 2023
@stale stale bot closed this as completed May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale Old issues that went stale
Projects
None yet
Development

No branches or pull requests

1 participant