Skip to content

Commit 442e867

Browse files
committed
fix promise test
1 parent 2a33471 commit 442e867

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

jscomp/test/js_promise_basic_test.js

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,10 @@ function allResolvedTest(param) {
241241
return obj.then(arg1);
242242
}
243243

244+
function is_not_found(error) {
245+
return error.RE_EXN_ID === "Not_found";
246+
}
247+
244248
function allRejectTest(param) {
245249
var p1 = Promise.resolve(1);
246250
var p2 = Promise.resolve(3);
@@ -255,9 +259,7 @@ function allRejectTest(param) {
255259
var obj = Promise.all(promises);
256260
var obj$1 = obj.then(fail);
257261
var arg1 = function (error) {
258-
assert_bool(error === ({
259-
RE_EXN_ID: "Not_found"
260-
}));
262+
assert_bool(error.RE_EXN_ID === "Not_found");
261263
return h;
262264
};
263265
return obj$1.catch(arg1);
@@ -287,9 +289,7 @@ function createPromiseRejectTest(param) {
287289
});
288290
}));
289291
var arg1 = function (error) {
290-
assert_bool(error === ({
291-
RE_EXN_ID: "Not_found"
292-
}));
292+
assert_bool(error.RE_EXN_ID === "Not_found");
293293
return h;
294294
};
295295
return obj.catch(arg1);
@@ -343,7 +343,7 @@ var obj = Promise.all([
343343
]);
344344

345345
function arg1(param) {
346-
eq("File \"js_promise_basic_test.ml\", line 168, characters 12-19", [
346+
eq("File \"js_promise_basic_test.ml\", line 171, characters 12-19", [
347347
param[0],
348348
param[1]
349349
], [
@@ -369,7 +369,7 @@ function re(prim) {
369369

370370
Mt.from_promise_suites("Js_promise_basic_test", {
371371
hd: [
372-
"File \"js_promise_basic_test.ml\", line 188, characters 5-12",
372+
"File \"js_promise_basic_test.ml\", line 191, characters 5-12",
373373
twop.then(function (x) {
374374
return Promise.resolve({
375375
TAG: /* Eq */0,
@@ -380,7 +380,7 @@ Mt.from_promise_suites("Js_promise_basic_test", {
380380
],
381381
tl: {
382382
hd: [
383-
"File \"js_promise_basic_test.ml\", line 189, characters 5-12",
383+
"File \"js_promise_basic_test.ml\", line 192, characters 5-12",
384384
twop.then(function (x) {
385385
return Promise.resolve({
386386
TAG: /* Neq */1,
@@ -416,6 +416,7 @@ exports.rejectTest = rejectTest;
416416
exports.thenCatchChainResolvedTest = thenCatchChainResolvedTest;
417417
exports.thenCatchChainRejectedTest = thenCatchChainRejectedTest;
418418
exports.allResolvedTest = allResolvedTest;
419+
exports.is_not_found = is_not_found;
419420
exports.allRejectTest = allRejectTest;
420421
exports.raceTest = raceTest;
421422
exports.createPromiseRejectTest = createPromiseRejectTest;

jscomp/test/js_promise_basic_test.ml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,14 +113,17 @@ let allResolvedTest () =
113113
assert_bool (resolved.(2) = 3);
114114
h)
115115

116+
let is_not_found (error : exn) =
117+
match error with Not_found -> true | _ -> false
118+
116119
let allRejectTest () =
117120
let p1 = resolve 1 in
118121
let p2 = resolve 3 in
119122
let p3 = reject Not_found in
120123
let promises = [| p1; p2; p3 |] in
121124
all promises |> then_ fail
122125
|> catch (fun error ->
123-
assert_bool (Obj.magic error == Not_found);
126+
assert_bool (is_not_found (Obj.magic error));
124127
h)
125128

126129
let raceTest () =
@@ -133,7 +136,7 @@ let raceTest () =
133136
let createPromiseRejectTest () =
134137
make (fun ~resolve ~reject -> (reject Not_found [@bs]))
135138
|> catch (fun error ->
136-
assert_bool (Obj.magic error == Not_found);
139+
assert_bool (is_not_found (Obj.magic error));
137140
h)
138141

139142
let createPromiseFulfillTest () =

0 commit comments

Comments
 (0)