Skip to content

Sync up with rescript-editor-support c57ed6d6c5a8f0ac93e0ae1878fd8d0a… #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cristianoc
Copy link
Collaborator

…fb1a63d3

Sync up with rescript-lang/rescript-editor-support@c57ed6d

New features

  • Add support for autocomplete for pipe-first foo->: the type of foo is used to determine the module to take completions from.
  • Add support for autocomplete for decorators such as @module and @val.
  • Add support for autocomplete of labelled arguments foo(~label... ).

Fixes

Sync up with rescript-lang/rescript-editor-support@c57ed6d

#### New features
- Add support for autocomplete for pipe-first `foo->`: the type of `foo` is used to determine the module to take completions from.
- Add support for autocomplete for decorators such as `@module` and `@val`.
- Add support for autocomplete of labelled arguments `foo(~label... )`.

#### Fixes

- Fix issue for uncurried functions where the internal definition of `Js.Fn.arity` is shown on hover. (See rescript-lang/rescript-editor-support#62).
- Fix type hint when hovering over labeled arguments of components (See rescript-lang/rescript-editor-support#63).
- Fix issue where values declared with type annotation would not show up in autocomplete, and would show no doc comment on hover. (See #72).
- Fix hover on definitions inside a react component module, or whenever multiple definitins for the same value exist in the module (See rescript-lang/rescript-editor-support#67).
- Fix autocomplete issue where multiple open's were considered in the wrong priority order (See rescript-lang/rescript-editor-support#72).
@chenglou
Copy link
Member

Nice, nice

@chenglou chenglou merged commit 951e285 into master Mar 15, 2021
@chenglou chenglou deleted the rescript-editor-support-c57ed6d6c5a8f0ac93e0ae1878fd8d0afb1a63d3 branch March 15, 2021 22:54
chenglou added a commit that referenced this pull request Apr 23, 2021
chenglou added a commit that referenced this pull request Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants