Skip to content

[Poc]: Doc extraction continuation (PR 732) #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 8, 2023
Merged

[Poc]: Doc extraction continuation (PR 732) #780

merged 5 commits into from
Aug 8, 2023

Conversation

aspeddro
Copy link
Contributor

@aspeddro aspeddro commented Jun 1, 2023 •
edited
Loading

This PR add more information to output:

  1. Emit an optional field for optional fields in records.
  2. Emit a location field for the location of the function, module or type in the source file.
  3. Emit a field when @deprecated or @@deprecated attribute is used.

Continuation of #732

@zth zth changed the base branch from master to doc-extraction June 2, 2023 05:53
@aspeddro aspeddro marked this pull request as ready for review June 13, 2023 22:13
@aspeddro
Copy link
Contributor Author

aspeddro commented Jun 13, 2023 •
edited
Loading

I removed the field location

Note: When @deprecated attribute is used then doc extraction will emit an empty string.

{
  "deprecated": ""
}

@zth
Copy link
Collaborator

zth commented Aug 8, 2023

Mergin this. Thanks @aspeddro !

@zth zth merged commit 8deb41f into rescript-lang:doc-extraction Aug 8, 2023
@aspeddro aspeddro deleted the doc-extraction-aspeddro branch October 12, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aspeddro @zth