Skip to content

Incorrect type when hovering over a React element that uses a module alias #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cknitt opened this issue Apr 27, 2021 · 2 comments · Fixed by #241
Closed

Incorrect type when hovering over a React element that uses a module alias #180

cknitt opened this issue Apr 27, 2021 · 2 comments · Fixed by #241
Labels
jsx Issue with ppx for JSX

Comments

@cknitt
Copy link
Member

cknitt commented Apr 27, 2021

(Beta2)

Given

module A = {
  @react.component
  let make = (~children: React.element) => children
}

module A1 = A

let _ = <A> <div /> <div /> </A>

let _ = <A1> <div /> <div /> </A1>

hover shows the following:

Bildschirmfoto 2021-04-27 um 19 23 42

Bildschirmfoto 2021-04-27 um 19 23 54

(and Go to Definition does not work for A1)

@cristianoc cristianoc added the jsx Issue with ppx for JSX label Apr 28, 2021
@cristianoc
Copy link
Collaborator

Labeling all these with jsx meaning: not going to address them separately from changes to the ppx for JSX.

@cristianoc
Copy link
Collaborator

Looks like this is already fixed in master: #241

cristianoc added a commit that referenced this issue May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jsx Issue with ppx for JSX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants