Skip to content

Hover over React component declaration in .resi file shows incorrect type information #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cknitt opened this issue Apr 27, 2021 · 1 comment
Closed

Hover over React component declaration in .resi file shows incorrect type information #177

cknitt opened this issue Apr 27, 2021 · 1 comment
Labels
jsx Issue with ppx for JSX

Comments

@cknitt
Copy link
Member

cknitt commented Apr 27, 2021

(Beta2)

In the .resi, the result type is wrong (should be React.element).
Also ~key and unit are shown for .resi, but not for .res.

A.res:

@react.component
let make = (~a) => React.string(a)

Bildschirmfoto 2021-04-27 um 18 46 13

A.resi:

@react.component
let make: (~a: string) => React.element

Bildschirmfoto 2021-04-27 um 18 43 18
@cristianoc cristianoc mentioned this issue Apr 27, 2021
Closed
@cristianoc cristianoc added the jsx Issue with ppx for JSX label Apr 28, 2021
@cristianoc
Copy link
Collaborator

Labeling all these with jsx meaning: not going to address them separately from changes to the ppx for JSX.

cristianoc added a commit that referenced this issue Apr 30, 2021
@cristianoc
Add heuristic for hover on components in interface files.
ddceacf 
Fixes #177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
jsx Issue with ppx for JSX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cknitt @cristianoc