Skip to content

Improve ReadDOM properties using polyvariants #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dodomorandi
Copy link

I added some properties that could not be expressed correctly in ReasonML and added typing to others.
I just took the properties with meaningful comments about fixed states, therefore more work could be needed.

Just a small note: sandbox is quite tricky, because it should be a string containing space-separated fixed set of things. In practice we would need a list of an hypothetical Sandbox union type and it should be rendered as a joined string. I don't think that we have an easy way to express this, but if someone has an idea I will be happy to try something.

Closes #10

@rickyvetter
Copy link
Collaborator

Love this work, but we are moving all of this out of runtime into the ppx so the code that manages this will be in a different place. Landing this ahead of time would make it so we'd have two breaking changes so I don't think it's worth it.

Thanks for doing all this work and if you'd be interested I'd love to have you take a look at the ppx to make sure things are all in order and no support you were looking for is missing there. rescript-lang/syntax#235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polyvariant attributes: to bump or not to bump
2 participants