Improve ReadDOM properties using polyvariants #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some properties that could not be expressed correctly in ReasonML and added typing to others.
I just took the properties with meaningful comments about fixed states, therefore more work could be needed.
Just a small note:
sandbox
is quite tricky, because it should be a string containing space-separated fixed set of things. In practice we would need a list of an hypotheticalSandbox
union type and it should be rendered as a joined string. I don't think that we have an easy way to express this, but if someone has an idea I will be happy to try something.Closes #10