Skip to content

Dynamic imports v11 blog post #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 5, 2023
Merged

Dynamic imports v11 blog post #683

merged 9 commits into from
Jun 5, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented May 16, 2023

Any feedback welcome.

Copy link
Contributor

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great.

A minor commenta and a Q: what's the current state of the art in TS for checking dynamic imports: when the path is not correct or the type of the module is not correct is there a way to get notified by a type error?

@ryyppy
Copy link
Member

ryyppy commented Jun 2, 2023

@cknitt I drastically reduced the content of the blog post to make it as on-point as possible, so please have a look again if this looks fine.

@cristianoc: A minor commenta and a Q: what's the current state of the art in TS for checking dynamic imports: when the path is not correct or the type of the module is not correct is there a way to get notified by a type error?

In TS, in both cases it will either raise a "module not found" or a type error. The tooling is really good in that regard. Our main advantage is that ReScript is just "simpler" by nature (less tsconfig madness, less considerations about what file extension should be used in the import path, etc. etc.).

@ryyppy ryyppy merged commit 155bf65 into master Jun 5, 2023
@ryyppy ryyppy deleted the dynamic-import-post branch June 5, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants