Update Js.String[2].match_ return type #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Js.String2.match_` and `Js.String.match_` return type was changed in rescript-lang/rescript#5070 and released on 10.0.0. This commit updates the API documentation. close rescript-lang#551
`/** */` is considered as doc comment now. The old example just uses it as multi-line comments for print output. Thus, I change it to `/* */` instead.
cristianoc
reviewed
Sep 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update test example script to test against rescript 10.0.0.
Otherwise,
npm testwill not pass since updated code samples require rescript 10.0.0.close #551