This repository was archived by the owner on Apr 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Switch PrintType.re to syntax outcome printer. #33
Comments
Should we use syntax repo as a submodule for this or just vendor desired modules? |
The missing cases currently fall back to let typexp sch ppf ty =
!Oprint.out_type ppf (tree_of_typexp sch ty)
let type_expr ppf ty = typexp false ppf ty So one would use the same logic but replace |
cristianoc
added a commit
that referenced
this issue
Dec 1, 2020
Fixes #33 - Vendor the ourcome printer from https://github.com/rescript-lang/syntax - Make monads ppx use 406 AST to compile the vendored code (inline records) - Pass around / calculate recursion status to correctly print multiple and recursive type definitions.
cristianoc
added a commit
that referenced
this issue
Dec 2, 2020
Fixes #33 - Vendor the ourcome printer from https://github.com/rescript-lang/syntax - Make monads ppx use 406 AST to compile the vendored code (inline records) - Pass around / calculate recursion status to correctly print multiple and recursive type definitions.
chenglou
pushed a commit
to chenglou/rescript-editor-support
that referenced
this issue
Apr 24, 2021
Fixes rescript-lang#33 - Vendor the ourcome printer from https://github.com/rescript-lang/syntax - Make monads ppx use 406 AST to compile the vendored code (inline records) - Pass around / calculate recursion status to correctly print multiple and recursive type definitions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
PrintType.re
currently uses some custom code to print types. The outcome printer from the syntax repo implements the same functionality: https://github.com/rescript-lang/syntax/blob/master/src/res_outcome_printer.ml and has tests.To reduce complexity and provide a better printing experience for the user we should switch to the outcome printer of the syntax repo. Types can be converted to the
Outcometree
with the compiler-libs if I recall correctly.The text was updated successfully, but these errors were encountered: