Start moving airgap e2e tests to CMX #2117
Conversation
sgalsaleh
changed the title
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
| @@ -73,11 +82,28 @@ runs: | |||
| with: | |||
| go-version-file: go.mod | |||
| cache-dependency-path: "**/*.sum" | |||
| - name: Install replicated CLI for CMX | |||
There was a problem hiding this comment.
we should make a github action for this!
There was a problem hiding this comment.
why not use the replicated / vendor-cli docker image that's published to do these?
There was a problem hiding this comment.
so using the docker image is recommended over the binary published to github?
| t.Logf("%s: downloading airgap files", time.Now().Format(time.RFC3339)) | ||
| airgapInstallBundlePath := "/tmp/airgap-install-bundle.tar.gz" | ||
| airgapUpgradeBundlePath := "/tmp/airgap-upgrade-bundle.tar.gz" | ||
| tc := cmx.NewCluster(&cmx.ClusterInput{ |
There was a problem hiding this comment.
can we add comments to the TestSingleNodeAirgapUpgradeCustomCIDR and TestSingleNodeAirgapUpgrade entries in the test array within ci.yaml to say that they now use CMX?
sgalsaleh
force-pushed
the
run-reset-and-reinstall-airgap-test-on-cmx
branch
4 times, most recently
from
8c3e78d to
ae404cc
Compare
sgalsaleh
force-pushed
the
run-reset-and-reinstall-airgap-test-on-cmx
branch
from
ae404cc to
21d130a
Compare
| return nil | ||
| } | ||
|
|
||
| func (c *Cluster) RefreshSSHEndpoints() error { |
There was a problem hiding this comment.
it was used in one of the tests that i decided to retract to merge this pr. will definitely be needed for tests that include a reset and then re-install. i agree it's unused in this pr though yeah.
| cmd := exec.Command("replicated", "vm", "ssh-endpoint", nodeID) | ||
| output, err := cmd.CombinedOutput() | ||
| if err != nil { | ||
| return "", fmt.Errorf("failed to get SSH endpoint for node %s: %v: %s", nodeID, err, string(output)) |
There was a problem hiding this comment.
| return "", fmt.Errorf("failed to get SSH endpoint for node %s: %v: %s", nodeID, err, string(output)) | |
| return "", err |
| return fmt.Errorf("fail to bypass kurl-proxy: %v: %s", err, string(stderr)) | ||
| } | ||
| c.t.Logf("%s: installing playwright", time.Now().Format(time.RFC3339)) | ||
| cmd := exec.Command("sh", "-c", "cd playwright && npm ci && npx playwright install --with-deps") |
There was a problem hiding this comment.
is this quick each subsequent time it is run? i assume it is run on the runner once for each test. should we just make this a required dependency like the replicated cli?
There was a problem hiding this comment.
we only run this setup step once per test.
|
Merging as the |
What this PR does / why we need it:
Moves these airgap tests to CMX:
Which issue(s) this PR fixes:
sc-122461
Does this PR require a test?
Yes
Does this PR require a release note?
Does this PR require documentation?
NONE