fix: move with-props runtime logic to core library
#13650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e2d84f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
markdalgleish
changed the title
with-props logic to core librarywith-props runtime logic to core library
jacob-ebey
approved these changes
May 21, 2025
pcattori
approved these changes
May 21, 2025
MichaelDeBoey
approved these changes
May 21, 2025
|
🤖 Hello there, We just published version Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was initially designed to expose these utils for use in the preview RSC Parcel plugin, but I realised this is a useful change to ship immediately since it results in 1 fewer network requests on page load. It also cleans up the internals quite a bit and removes some duplication between
react-routerand@react-router/dev.Before:
After: