fix: make `replace` optional in type declaration and update JSDoc #137

remarkablemark · 2020-02-08T22:30:16Z

What is the motivation for this pull request?

Fixes index.d.ts by making replace property optional in the 2nd argument object.

Also, updated and fixed incorrect JSDoc in lib/dom-to-react.js.

If a 2nd argument is specified, replace is required so instead of:

{ replace: undefined }

Developers are forced to:

{ replace: () => {} }

Developers are no longer forced to satisfy the type requirements. See above.

And update the return types See #134

coveralls · 2020-02-08T22:32:20Z

Coverage remained the same at 100.0% when pulling 801512b on fix/types into ccba051 on master.

remarkablemark added 2 commits February 6, 2020 23:51

docs(lib): update JSDoc in dom-to-react

98baf39

fix(index): make replace property optional in index.d.ts

801512b

And update the return types See #134

remarkablemark merged commit f8c0e3f into master Feb 8, 2020

remarkablemark deleted the fix/types branch February 8, 2020 22:35