Skip to content

Parser completely removes body elements if html string has open <html> and <body> tags, but does not have close </body> and </html> tags #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sanex3339 opened this issue Oct 28, 2019 · 2 comments
Closed

Parser completely removes body elements if html string has open <html> and <body> tags, but does not have close </body> and </html> tags #126

sanex3339 opened this issue Oct 28, 2019 · 2 comments

Comments

@sanex3339
Copy link

Expected Behavior

Parser should try to keep all existing html tags if html string has open and tags, but does not have close and tags

Actual Behavior

Parser completely removes all body elements if html string has open and tags, but does not have close and tags

Steps to Reproduce

Just try to parse following html string:

 <html>
        <body>
          <h1 style="font-family: Arial;">
            html-react-parser
          </h1>

Reproducible Demo

https://jsfiddle.net/rxzudvmf/

Environment

  • Version: 0.9.1
  • Platform: Mac OS
  • Browser: Chrome 77
@sanex3339
Copy link
Author

Looks like a problem of html-dom-parser

@remarkablemark remarkablemark mentioned this issue Oct 31, 2019
Closed
remarkablemark added a commit that referenced this issue Nov 4, 2019
@remarkablemark
build(package): upgrade dependency [email protected]
891eda4 
 html-dom-parser    0.2.2  →   0.2.3

This fixes a bug related to client-side DOM parsing for unclosed
HTML markup.

Relates to #126 and remarkablemark/html-dom-parser#18
@remarkablemark remarkablemark mentioned this issue Nov 4, 2019
Merged
@remarkablemark
Copy link
Owner

[email protected] has been released and published:

# update with npm
npm i -S [email protected]

# or with yarn
yarn add [email protected]

Let me know if this resolves the issue for you @sanex3339.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanex3339 @remarkablemark