Skip to content

Parsing does not work on server side #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rgavinc opened this issue Jul 2, 2019 · 4 comments · Fixed by #116
Closed

Parsing does not work on server side #115

rgavinc opened this issue Jul 2, 2019 · 4 comments · Fixed by #116
Labels
bug Something isn't working

Comments

@rgavinc
Copy link

rgavinc commented Jul 2, 2019

Because of the changes made by this commit, parsing does not work on the server side. This is a problem for server-rendered React applications.
@remarkablemark
Copy link
Owner

Yes you're right @rgavinc. I was able to reproduce the issue in Repl.it.

I'll revert commit 1fb5ee2.

@remarkablemark remarkablemark added the bug Something isn't working label Jul 3, 2019
remarkablemark added a commit that referenced this issue Jul 3, 2019
@remarkablemark
revert: feat(dom-to-react): skip and do not parse <script> content
e625e1d 
This reverts commit 1fb5ee2.

The reason for the revert is because removing the <script> from
the parsing causes server-side rendering to break.

Fixes #115
@remarkablemark remarkablemark mentioned this issue Jul 3, 2019
Merged
@remarkablemark
Copy link
Owner

@rgavinc I released and published [email protected]:

# npm
npm i -S [email protected]

# yarn
yarn add [email protected]

@Gus19
Copy link

Gus19 commented Sep 9, 2020

Because of the changes made by this commit, parsing does not work on the server side. This is a problem for server-rendered React applications.

Hello, I have the same problem with 0.13 version, it's normal ?

@remarkablemark
Copy link
Owner

Issue should be fixed @Gus19. Can you provide a reproducible example using Repl.it?

And to note, script tags are not evaluated on the client-side. See FAQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@Gus19 @remarkablemark @rgavinc