Skip to content

feat: add esm for client #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AlbertAZ1992
Copy link
Contributor

@AlbertAZ1992 AlbertAZ1992 commented Aug 16, 2022

What is the motivation for this pull request?

Closes #327

What is the current behavior?

What is the new behavior?

Checklist:

Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #331 (0c4c2b6) into master (154d81f) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   94.20%   94.28%   +0.08%     
==========================================
  Files           7        7              
  Lines         138      140       +2     
==========================================
+ Hits          130      132       +2     
  Misses          8        8              
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@remarkablemark remarkablemark merged commit 4bdfc37 into remarkablemark:master Aug 16, 2022
@remarkablemark
Copy link
Owner

Released #332 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest ESM support
3 participants