Skip to content

Update README.md #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
keigohtr merged 3 commits into from
Dec 25, 2018
Merged

Update README.md #22

keigohtr merged 3 commits into from
Dec 25, 2018

Conversation

@keigohtr
Copy link
Member

@keigohtr keigohtr commented Dec 21, 2018

What is this PR for?

To accelerate expanding Rekcurd, we need to update our installation manual.

@keigohtr keigohtr self-assigned this Dec 21, 2018
@codecov-io
Copy link

codecov-io commented Dec 21, 2018 •
edited
Loading

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   87.46%   87.46%           
=======================================
  Files          16       16           
  Lines        1037     1037           
=======================================
  Hits          907      907           
  Misses        130      130

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37fd398...944aae8. Read the comment docs.

yuki-mt
yuki-mt reviewed Dec 21, 2018
View reviewed changes
Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same suggestion as this comment ( rekcurd/dockerfiles#2 (comment) ) about writing code in drucker-example repository on README

@keigohtr
Copy link
Member Author

keigohtr commented Dec 25, 2018

@yuki-mt Thank you!
I have removed the redundant info. Could you check it again please?

@keigohtr keigohtr mentioned this pull request Dec 25, 2018
Merged
@yuki-mt
Copy link
Member

yuki-mt commented Dec 25, 2018

@keigohtr

Sorry for overlooking, but it looks that template directory is also very similar to drucker-example.
I guess we can use drucker-example code as template and should remote template directory.
Do you agree?

@keigohtr
Copy link
Member Author

keigohtr commented Dec 25, 2018

I am using template for debugging but it's OK.
I have removed.

yuki-mt
yuki-mt approved these changes Dec 25, 2018
View reviewed changes
Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keigohtr keigohtr merged commit 67a4e4e into master Dec 25, 2018
@keigohtr keigohtr deleted the fix/update-readme-20181221 branch December 25, 2018 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuki-mt yuki-mt yuki-mt approved these changes

@sugyan sugyan Awaiting requested review from sugyan

@yoquankara yoquankara Awaiting requested review from yoquankara

@yustoris yustoris Awaiting requested review from yustoris

@jkw552403 jkw552403 Awaiting requested review from jkw552403

@shimpei-yotsukura shimpei-yotsukura Awaiting requested review from shimpei-yotsukura

Assignees

@keigohtr keigohtr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@keigohtr @codecov-io @yuki-mt