export types, prepare TS config for migrating files #3537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdorr
reviewed
Aug 30, 2019
src/index.ts
Outdated
| @@ -1,9 +1,31 @@ | |||
| import { | |||
There was a problem hiding this comment.
Can we just use export Foo from 'foo' syntax here? Or is there some sort of optimization thing I'm forgetting about?
There was a problem hiding this comment.
yes, I re-organized to put type exports at the top, take a peek. Not sure if we can continue to use export * from... once the types are in the files, we shall see
cellog
force-pushed
the
cellog-3500-index.ts
branch
from
24a371b to
6378591
Compare
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last of the first step for #3500
woot!