Alternate: Add ability for slices to listen to other actions

[Dudeonyx]

Implemented my proposed changes from #83 (comment)

@denisw @markerikson your inputs are appreciated

Note: this PR is for the feature/other-slice-action branch not master

• Removed getType() utility

• slice is no longer attached to actionsMap and reducerMap

• Removed reducerMap and directly forward reducers to createReducer

• createAction() action creators type property returns a string literal for better type saftey

• Fixed tests

• Added tests

[netlify]

Deploy preview for redux-starter-kit-docs ready!

Built with commit 09abf7b

https://deploy-preview-86--redux-starter-kit-docs.netlify.com

[markerikson]

Per my comment in the other thread, this appears to be removing functionality that I want to keep. I don't think this is the direction I want to go.

[Dudeonyx]

@markerikson In that case, I've reverted the changes so slice is still attached to the action creators.

The only changes here are to the typing of createAction() action creator type and toString() properties, making the them string literals instead of generic strings

[markerikson]

Okay. one other question. @Jessidhia mentioned something in Reactiflux about &-ing the action creator with a string, possibly in the return value of createAction:

[7:13 PM] Jessie : acemarke to the return type of createAction; it will probably need an as cast
[7:13 PM] Jessie : const result = ...; return result as typeof result & string

Would that allow the action creator itself to be used directly as a key in an object, without a TS2464 error like microsoft/TypeScript#14207 ?

[Dudeonyx]

@markerikson I've tried that and while doing something like

export function createAction<P = any, T extends string = string>(
  type: T
): PayloadActionCreator<P, T> & T {  // <- note the `& T`
  function actionCreator(): Action<T>
  function actionCreator(payload: P): PayloadAction<P, T>
  function actionCreator(payload?: P): Action<T> | PayloadAction<P, T> {
    return { type, payload }
  }

  actionCreator.toString = (): T => `${type}` as T

  actionCreator.type = type

  return actionCreator as any // <- typecast as any to prevent errors
}

allows you to use the action creator as object key without TS errors. Typescript will just treat it like a generic string in that case which breaks type safety.

const reducers = {
  [increment]: (state,payload) => state + payload
}

// reducers will have type { [x:string]: (number, number) => number }

So I think it's better for TS users to explicitly use the action creator type property or toString() method which now return string literals. Of course JS users are unaffected by this.