Skip to content

WIP: TypeScript support #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

WIP: TypeScript support #32

wants to merge 12 commits into from

Conversation

nickserv
Copy link
Collaborator

@nickserv nickserv commented Apr 24, 2018 •
edited
Loading

Fixes #30, it seems like a lot of extra work to also support Flow so I'm ignoring it for now.

  • Fix finalCompose type error
  • Port sources to TypeScript to strongly type internal values
  • Port tests to TypeScript
  • Use "strict": true
  • Declarations for selectorator (I'm working on an upstream PR)
  • Consider waiting on Support Redux 4 #28 (Redux 4 will likely require adjusting types)

@nickserv nickserv changed the title TypeScript support WIP: TypeScript support Apr 24, 2018
@nickserv
Copy link
Collaborator Author

nickserv commented May 4, 2018

I underestimated how much work this would be, I'm going to give up on this for now. Hopefully it'll be easier to get back to this in the future after we change our API.

@nickserv nickserv closed this May 4, 2018
phryneas added a commit that referenced this pull request Nov 2, 2021
@buzzie-bee @msutkowski @phryneas
Fix #32 by appending ./ to relative imports from the same folder (#38)
609b066 
Co-authored-by: Matt Sutkowski <[email protected]>
Co-authored-by: Lenz Weber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nickserv