Remove re-exports #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'm still really not sold on this idea. I think I can agree with not re-exporting the stuff from Redux, because we expect the user to have that installed already, but I really want a selector library included in here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19, please refer to it for my rationale.
I removed the dependency on selectorator and some re-exports of Immer and Redux functions. The goal is not to discourage their use, but encourage users to install companion packages separate for more flexible versioning and so they're not locked into the versions bundled with this package. I tried to preserve the docs for the formerly re-exported functions, but I'm not sure about the placement within the readme and wording, so I'm open to suggestions.