Error when using HMR

[theverything]

I recently updated react-redux@5.0.0-beta.3. After doing so I noticed that after every code change HMR would cause a full page refresh do to an error.

I looked through the stack trace and the error comes from react-redux.

Subscription.js:67 Uncaught (in promise) TypeError: this.subscribe is not a function
    at Subscription.trySubscribe (Subscription.js:67)
    at Subscription.addNestedSub (Subscription.js:53)
    at Subscription.trySubscribe (Subscription.js:67)
    at ProxyComponent.componentWillUpdate (connectAdvanced.js:246)
    at ProxyComponent.componentWillUpdate (createPrototypeProxy.js:44)
    at react.js:6605
    at measureLifeCyclePerf (react.js:5971)
    at ReactCompositeComponentWrapper._performComponentUpdate (react.js:6604)
    at ReactCompositeComponentWrapper.updateComponent (react.js:6539)
    at ReactCompositeComponentWrapper.receiveComponent (react.js:6441)

I reverted back to react-redux@4.4.5 and the error went away and HMR started working correctly again.

software	version
react	15.3.2
webpack	2.1.0-beta.25
redux	3.6.0
node	6.7.0
npm	3.10.3

[jimbolla]

@theverything I'm not exactly sure how to reproduce this. Any chance you can provide a repo?

[theverything]

I can't share the repo that the error is happening with, but I am trying to create an other one to reproduce the issue.

[theverything]

I haven't been able to create a project to reproduce the error. I did try the beta again in my current project and the error still persists. Let me know if there is any way I can help.

[jimbolla]

Is there any way you can share your project, even a stripped down one with me the demonstrates the problem? With that I could reduce the code into a test case.

[theverything]

I tried that but there was no error. 😞

[jimbolla]

Maybe in stripping it down, you removed some key part that's causing react-redux to have the problem.

[theverything]

Thats what I'm thinking.

[jimbolla]

@theverything Anything I can do to help you with this? I'd love to resolve this one to help v5 make it to release. If you can't share your code with me, what about a screen-sharing session? Maybe from that I can see enough to make a repro without it.

[timdorr]

Without a repro, there isn't really anything to be done here. I'll reopen if there is something that can be reproduced, but HMR itself is known to have issues and may be the culprit here.

[patrikholcak]

@timdorr Recently discovered the same error — here’s the project. If you try to HMR ./src/routes/counter.js you’ll see the exact same error. Downgrading to react-redux@^4.4.6 fixed it

[mshustov]

Hi. guys. I ran into the same problem. Seems the reason is that connectAdvanced doesn't update link to subscription after updating. So I added my updating mechanism and it works for my project.
If it's okay for you, I could add some tests and send PR