Skip to content

Commit d083422

Browse files
committed
Remove no-resolution flag when running are-the-types-wrong during CI
- `@arethetypeswrong/cli` now has an `--exclude-entrypoints` flag which we can use to exclude the `alternate-renderers` entrypoint from the check since it will fail under the `Node10` module resolution as `Node10` looks at actual files on disk and we don't have a file named `alternate-renderers`.
1 parent 098f862 commit d083422

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,8 @@ jobs:
9393
path: .
9494

9595
# Note: We currently expect "FalseCJS" failures for Node16 + `moduleResolution: "node16",
96-
# and the `/alternateRenderers" entry point will not resolve under Node10.
97-
# Skipping these is dangerous, but we'll leave it for now.
9896
- name: Run are-the-types-wrong
99-
run: npx @arethetypeswrong/cli ./package.tgz --format table --ignore-rules false-cjs no-resolution
97+
run: npx @arethetypeswrong/cli ./package.tgz --format table --ignore-rules false-cjs --exclude-entrypoints alternate-renderers
10098

10199
test-published-artifact:
102100
name: Test Published Artifact ${{ matrix.example }}

0 commit comments

Comments
 (0)