-
Notifications
You must be signed in to change notification settings - Fork 296
replace lodash with just, replace webpack with rollup, transpile dependencies #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a0118f3
to
d6f982a
Compare
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 27 27
Lines 132 132
Branches 39 39
=======================================
Hits 127 127
Misses 4 4
Partials 1 1
Continue to review full report at Codecov.
|
69891a8
to
f690692
Compare
f690692
to
c38db85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! Looks good apart from a change in a unit test.
test/camelCase.test.js
Outdated
@@ -9,5 +9,5 @@ test('includes forward slashes in words', () => { | |||
}); | |||
|
|||
test('does nothing to an already camel-cased action type', () => { | |||
expect(camelCase('myAction')).toBe('myAction'); | |||
expect(camelCase('myAction')).toBe('myaction'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix this behaviour, because it shouldn't do anything to the string according to the spec.
Wondering if I should revert to the way redux-actions handled the commonjs and es builds before. Using rollup creates a single-file commonjs build, which has benefits but maybe be a jarring API change for users that want to import a file directly from |
It would be nice to merge this! Great work @heygrady |
So do u think there any breaking changes? |
No. But the previous build did separate files in the lib folder, like this: This build will have a single file. With the new build you can still do |
Can we change this to the old behaviour? Because I see this as potentially breaking. |
848f758
to
8ecf5b9
Compare
Thanks 👍 |
fixes #331
Notes: