Skip to content

Commit 803f03e

Browse files
fix test and rename var
1 parent 0cfc614 commit 803f03e

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

redisvl/extensions/llmcache/semantic.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,8 @@ def delete(self) -> None:
188188

189189
def _refresh_ttl(self, key: str) -> None:
190190
"""Refresh the time-to-live for the specified key."""
191-
if self.ttl:
192-
self._index.client.expire(key, self.ttl) # type: ignore
191+
if self._ttl:
192+
self._index.client.expire(key, self._ttl) # type: ignore
193193

194194
def _vectorize_prompt(self, prompt: Optional[str]) -> List[float]:
195195
"""Converts a text prompt to its vector representation using the

tests/integration/test_llmcache.py

+5-12
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ def cache(vectorizer, redis_url):
1919
vectorizer=vectorizer, distance_threshold=0.2, redis_url=redis_url
2020
)
2121
yield cache_instance
22-
cache_instance.clear() # Clear cache after each test
2322
cache_instance._index.delete(True) # Clean up index
2423

2524

@@ -37,7 +36,6 @@ def cache_with_ttl(vectorizer, redis_url):
3736
vectorizer=vectorizer, distance_threshold=0.2, ttl=2, redis_url=redis_url
3837
)
3938
yield cache_instance
40-
cache_instance.clear() # Clear cache after each test
4139
cache_instance._index.delete(True) # Clean up index
4240

4341

@@ -54,7 +52,7 @@ def cache_with_redis_client(vectorizer, client, redis_url):
5452
cache_instance._index.delete(True) # Clean up index
5553

5654

57-
# Test handling invalid input for check method
55+
# # Test handling invalid input for check method
5856
def test_bad_ttl(cache):
5957
with pytest.raises(ValueError):
6058
cache.set_ttl(2.5)
@@ -117,18 +115,13 @@ def test_ttl_expiration_after_update(cache_with_ttl, vectorizer):
117115
prompt = "This is a test prompt."
118116
response = "This is a test response."
119117
vector = vectorizer.embed(prompt)
120-
cache_with_ttl.set_ttl(5)
118+
cache_with_ttl.set_ttl(4)
121119

122-
cache_with_ttl.store(prompt, response, vector=vector)
123-
sleep(2)
124-
125-
check_result = cache_with_ttl.check(vector=vector)
126-
assert len(check_result) == 1
127-
print(check_result, flush=True)
128-
assert response == check_result[0]["response"]
129-
assert "metadata" not in check_result[0]
120+
assert cache_with_ttl.ttl == 4
130121

122+
cache_with_ttl.store(prompt, response, vector=vector)
131123
sleep(5)
124+
132125
check_result = cache_with_ttl.check(vector=vector)
133126
assert len(check_result) == 0
134127

0 commit comments

Comments
 (0)