Skip to content

Removing synchronous context manager handling from async RedisCluster. #3679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removing synchronous context manager handling from async RedisCluster. #3679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions redis/asyncio/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1581,15 +1581,6 @@ async def __aexit__(self, exc_type: None, exc_value: None, traceback: None) -> N
def __await__(self) -> Generator[Any, None, "ClusterPipeline"]:
return self.initialize().__await__()

def __enter__(self) -> "ClusterPipeline":
# TODO: Remove this method before 7.0.0
self._execution_strategy._command_queue = []
return self

def __exit__(self, exc_type: None, exc_value: None, traceback: None) -> None:
# TODO: Remove this method before 7.0.0
self._execution_strategy._command_queue = []

def __bool__(self) -> bool:
"Pipeline instances should always evaluate to True on Python 3+"
return True
Expand Down
Loading