Updated default value of 'require_full_coverage' argument to true for sync Cluster client to match sync/async cluster APIs #3434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does this PR mean to do? It's not clear from the title, description, or commit message? |
|
@akx Sorry for this, the PR description was updated |
|
@vladvildanov Should the word "much" in the title be "match"? 😅 |
vladvildanov
changed the title
|
@akx Oh, thank you! 😳 |
petyaslavova
changed the title
petyaslavova
approved these changes
Apr 29, 2025
petyaslavova
added a commit
that referenced
this pull request
Apr 30, 2025
… sync Cluster client to match sync/async cluster APIs (#3434) * Updated default value to much sync cluster API * Updated default value to TRUE --------- Co-authored-by: petyaslavova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
The goal of this PR if to fix misalignment between the default value of
require_full_coverageconfiguration option for sync/async clients. The default value was chosen to be True by default for safety reasons.