-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[WIP] Use Poetry as the dependency manager of this library #3257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this a good time to upgrade the outdated dependencies (including dev deps)? |
I took a little liberty to add some improvements to the workflow. If you don't like it or want any changes, don't hesitate to leave feedback. 😄
I did not tested this workflow yet, it can be broken. |
I'm getting some conflicts from the |
I wouldn't use Poetry for library packaging – it might be OK for applications, but I don't think it's the best fit for libraries. Please also see #1658 for previous discussion. |
Hi @bitterteriyaki, thank you for your efforts! We appreciate your contribution. Recently, the build process for the redis-py project was updated to use Hatchling as the backend build tool (PR #2930). Given this update, migrating to Poetry is not currently part of our planned changes. As a result, I’ll be closing this PR. Thanks again for your work! |
Pull Request check-list
Description of change
Use Poetry as the package manager of this library.
Checklist
setup.py
topyproject.toml
.flake8
,.isort.cfg
, etc.) intopyproject.toml
?CONTRIBUTING.md
fileREADME.md